ChainStringBuilderAppendCalls should not flatten a single argument#823
Merged
timtebeek merged 2 commits intoopenrewrite:mainfrom Feb 27, 2026
Merged
ChainStringBuilderAppendCalls should not flatten a single argument#823timtebeek merged 2 commits intoopenrewrite:mainfrom
ChainStringBuilderAppendCalls should not flatten a single argument#823timtebeek merged 2 commits intoopenrewrite:mainfrom
Conversation
b452b80 to
88026f7
Compare
Member
|
Yes that proposed fix makes sense to me! Thanks for reporting in detail & coming up with a solution. |
timtebeek
approved these changes
Feb 27, 2026
ChainStringBuilderAppendCalls should not flatten a single argument
mergify bot
added a commit
to robfrank/linklift
that referenced
this pull request
Mar 10, 2026
… 2.28.0 to 2.29.0 [skip ci] Bumps [org.openrewrite.recipe:rewrite-static-analysis](https://github.com/openrewrite/rewrite-static-analysis) from 2.28.0 to 2.29.0. Release notes *Sourced from [org.openrewrite.recipe:rewrite-static-analysis's releases](https://github.com/openrewrite/rewrite-static-analysis/releases).* > 2.29.0 > ------ > > What's Changed > -------------- > > * Remove mutable static field in ChainStringBuilderAppendCalls by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#822](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/822) > * `ChainStringBuilderAppendCalls` should not flatten a single argument by [`@motlin`](https://github.com/motlin) in [openrewrite/rewrite-static-analysis#823](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/823) > > New Contributors > ---------------- > > * [`@motlin`](https://github.com/motlin) made their first contribution in [openrewrite/rewrite-static-analysis#823](https://redirect.github.com/openrewrite/rewrite-static-analysis/pull/823) > > **Full Changelog**: <openrewrite/rewrite-static-analysis@v2.28.0...v2.29.0> Commits * [`63586c0`](openrewrite/rewrite-static-analysis@63586c0) Add failing test for spacing of single method invocation argument in append()... * [`017d753`](openrewrite/rewrite-static-analysis@017d753) Remove mutable static field in ChainStringBuilderAppendCalls ([#822](https://redirect.github.com/openrewrite/rewrite-static-analysis/issues/822)) * See full diff in [compare view](openrewrite/rewrite-static-analysis@v2.28.0...v2.29.0) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Added a failing test demonstrating that
ChainStringBuilderAppendCallsreformatsappend()arguments even when no chaining is needed. Whenappend()contains a single non-literal expression (e.g.String.format(...)),flatAdditiveExpressionsstrips the argument's whitespace prefix, causing the recipe to produce a whitespace-only diff on every cycle.What's your motivation?
A multiline
sb.append(String.format(...))call is being silently reformatted each cycle, collapsing the newline afterappend(into a single line. The recipe should be a no-op when there is nothing to chain.Anything in particular you'd like reviewers to focus on?
This is just a failing test, so we'll need to implement a fix before landing this. I believe the fix is an early return when
flattenExpressions.size() <= 1, since a single expression means there is no+concatenation to split into chained calls. This short-circuits before the grouping logic, which also prevents the prefix-stripping side effect fromflatAdditiveExpressions. Is this the right fix, and should we squash that fix into the same pull request?Checklist