Drop support for Node.js v12 & add support for Node.js v18#342
Merged
paescuj merged 9 commits intoopen-cli-tools:mainfrom Nov 26, 2022
paescuj:drop-node12-support-node18
Merged
Drop support for Node.js v12 & add support for Node.js v18#342paescuj merged 9 commits intoopen-cli-tools:mainfrom paescuj:drop-node12-support-node18
paescuj merged 9 commits intoopen-cli-tools:mainfrom
paescuj:drop-node12-support-node18
Conversation
Member
I like this idea with caveats. Node.js did a really awful job with the CJS/ESM compatibility, and going full ESM means never being useable in CJS codebases again (last I checked, that was the case at least). So my main point is: can we still support CJS codebases via transpiling somehow? It will also mean updating all imports to have file extensions. It's a one-off, but it'll be massive anyway.
I'd be happy to find alternative packages that work as well as these if we can't find any other way |
Merged
This comment was marked as outdated.
This comment was marked as outdated.
Closed
Collaborator
Author
|
I came up with #366 as an initial attempt... |
Collaborator
Author
|
@gustavohenke How do you feel about merging this along with #354? We can then treat #366 separately and merge it at a later time. |
gustavohenke
approved these changes
Nov 26, 2022
- allowJs / noImplicitAny are default values - Align with https://github.com/tsconfig/bases/blob/main/bases/node14.json
Collaborator
Author
Merged
renovate bot
referenced
this pull request
in creatorsgarten/contentsgarten
Mar 30, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [concurrently](https://togithub.com/open-cli-tools/concurrently) | [`^7.2.2` -> `^8.0.0`](https://renovatebot.com/diffs/npm/concurrently/7.6.0/8.0.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>open-cli-tools/concurrently</summary> ### [`v8.0.1`](https://togithub.com/open-cli-tools/concurrently/releases/tag/v8.0.1) [Compare Source](https://togithub.com/open-cli-tools/concurrently/compare/v8.0.0...v8.0.1) ##### What's Changed - Fix release workflow by [@​paescuj](https://togithub.com/paescuj) in [https://github.com/open-cli-tools/concurrently/pull/408](https://togithub.com/open-cli-tools/concurrently/pull/408) - Update dependencies by [@​paescuj](https://togithub.com/paescuj) in [https://github.com/open-cli-tools/concurrently/pull/409](https://togithub.com/open-cli-tools/concurrently/pull/409) **Full Changelog**: open-cli-tools/concurrently@v8.0.0...v8.0.1 ### [`v8.0.0`](https://togithub.com/open-cli-tools/concurrently/releases/tag/v8.0.0) [Compare Source](https://togithub.com/open-cli-tools/concurrently/compare/v7.6.0...v8.0.0) #### What's Changed - **Breaking change:** Drop support for Node.js v12 & add support for Node.js v18 by [@​paescuj](https://togithub.com/paescuj) in [https://github.com/open-cli-tools/concurrently/pull/342](https://togithub.com/open-cli-tools/concurrently/pull/342) - Add support for Bun by [@​jakeboone02](https://togithub.com/jakeboone02) in [https://github.com/open-cli-tools/concurrently/pull/406](https://togithub.com/open-cli-tools/concurrently/pull/406) - Add `--kill-signal` option by [@​paulsmithkc](https://togithub.com/paulsmithkc) in [https://github.com/open-cli-tools/concurrently/pull/402](https://togithub.com/open-cli-tools/concurrently/pull/402) - Fixed broken link in the readme by [@​abstractpoint](https://togithub.com/abstractpoint) in [https://github.com/open-cli-tools/concurrently/pull/390](https://togithub.com/open-cli-tools/concurrently/pull/390) #### New Contributors - [@​abstractpoint](https://togithub.com/abstractpoint) made their first contribution in [https://github.com/open-cli-tools/concurrently/pull/390](https://togithub.com/open-cli-tools/concurrently/pull/390) - [@​jakeboone02](https://togithub.com/jakeboone02) made their first contribution in [https://github.com/open-cli-tools/concurrently/pull/406](https://togithub.com/open-cli-tools/concurrently/pull/406) - [@​paulsmithkc](https://togithub.com/paulsmithkc) made their first contribution in [https://github.com/open-cli-tools/concurrently/pull/402](https://togithub.com/open-cli-tools/concurrently/pull/402) **Full Changelog**: open-cli-tools/concurrently@v7.6.0...v8.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/creatorsgarten/contentsgarten). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4yMi4xIiwidXBkYXRlZEluVmVyIjoiMzUuMjIuMSJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
referenced
this pull request
in zarf-dev/zarf
Mar 31, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [concurrently](https://togithub.com/open-cli-tools/concurrently) | [`7.6.0` -> `8.0.1`](https://renovatebot.com/diffs/npm/concurrently/7.6.0/8.0.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>open-cli-tools/concurrently</summary> ### [`v8.0.1`](https://togithub.com/open-cli-tools/concurrently/releases/tag/v8.0.1) [Compare Source](https://togithub.com/open-cli-tools/concurrently/compare/v8.0.0...v8.0.1) #### What's Changed - Fix release workflow by [@​paescuj](https://togithub.com/paescuj) in [https://github.com/open-cli-tools/concurrently/pull/408](https://togithub.com/open-cli-tools/concurrently/pull/408) - Update dependencies by [@​paescuj](https://togithub.com/paescuj) in [https://github.com/open-cli-tools/concurrently/pull/409](https://togithub.com/open-cli-tools/concurrently/pull/409) **Full Changelog**: open-cli-tools/concurrently@v8.0.0...v8.0.1 ### [`v8.0.0`](https://togithub.com/open-cli-tools/concurrently/releases/tag/v8.0.0) [Compare Source](https://togithub.com/open-cli-tools/concurrently/compare/v7.6.0...v8.0.0) #### What's Changed - **Breaking change:** Drop support for Node.js v12 & add support for Node.js v18 by [@​paescuj](https://togithub.com/paescuj) in [https://github.com/open-cli-tools/concurrently/pull/342](https://togithub.com/open-cli-tools/concurrently/pull/342) - Add support for Bun by [@​jakeboone02](https://togithub.com/jakeboone02) in [https://github.com/open-cli-tools/concurrently/pull/406](https://togithub.com/open-cli-tools/concurrently/pull/406) - Add `--kill-signal` option by [@​paulsmithkc](https://togithub.com/paulsmithkc) in [https://github.com/open-cli-tools/concurrently/pull/402](https://togithub.com/open-cli-tools/concurrently/pull/402) - Fixed broken link in the readme by [@​abstractpoint](https://togithub.com/abstractpoint) in [https://github.com/open-cli-tools/concurrently/pull/390](https://togithub.com/open-cli-tools/concurrently/pull/390) #### New Contributors - [@​abstractpoint](https://togithub.com/abstractpoint) made their first contribution in [https://github.com/open-cli-tools/concurrently/pull/390](https://togithub.com/open-cli-tools/concurrently/pull/390) - [@​jakeboone02](https://togithub.com/jakeboone02) made their first contribution in [https://github.com/open-cli-tools/concurrently/pull/406](https://togithub.com/open-cli-tools/concurrently/pull/406) - [@​paulsmithkc](https://togithub.com/paulsmithkc) made their first contribution in [https://github.com/open-cli-tools/concurrently/pull/402](https://togithub.com/open-cli-tools/concurrently/pull/402) **Full Changelog**: open-cli-tools/concurrently@v7.6.0...v8.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/defenseunicorns/zarf). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4yMi4xIiwidXBkYXRlZEluVmVyIjoiMzUuMjIuMSJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js v12 is EOL, so we should move away from it and support Node.js v18 (in "Active" state) instead.
See https://nodejs.org/en/about/releases/.
This is a breaking change and must be released under a new major version!
@gustavohenke What do you think about moving to pure ESM? This would also enable us to use newer versions of
chalkandsupports-colorwhich are pure ESM as well.Something else that we might consider is transpiling / bundling...