Skip to content

Switch to pnpm#354

Merged
paescuj merged 10 commits intoopen-cli-tools:mainfrom
paescuj:pnpm
Dec 29, 2022
Merged

Switch to pnpm#354
paescuj merged 10 commits intoopen-cli-tools:mainfrom
paescuj:pnpm

Conversation

@paescuj
Copy link
Collaborator

@paescuj paescuj commented Aug 11, 2022

pnpm feels like a great alternative to npm!

The only downside is that we could probably no longer use np (sindresorhus/np#251) but I'd suggest to automate the release process with a GitHub workflow, anyway.

To be merged after #342 (will update the pull request to use pnpm v7 then)

@coveralls
Copy link

coveralls commented Aug 11, 2022

Coverage Status

Coverage remained the same at 99.45% when pulling db48957 on paescuj:pnpm into ed3c18f on open-cli-tools:main.

@paescuj paescuj requested a review from gustavohenke August 17, 2022 21:08
Copy link
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only downside is that we could probably no longer use np

I've never used, tbh. I think that's a tool that @kimmobrunfeldt likes and documented somewhere 😄

@paescuj paescuj marked this pull request as ready for review November 14, 2022 01:13
@paescuj paescuj added this to the v8 milestone Nov 18, 2022
@paescuj paescuj requested a review from gustavohenke November 26, 2022 21:13
Copy link
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I think, is there anything still pending here? 😄

@paescuj
Copy link
Collaborator Author

paescuj commented Dec 28, 2022

LGTM I think, is there anything still pending here? 😄

Only the open conversation... I'm going to rebase and merge it afterwards 🚀

@paescuj paescuj merged commit ebc52c4 into open-cli-tools:main Dec 29, 2022
@paescuj paescuj deleted the pnpm branch December 29, 2022 01:48
@gustavohenke
Copy link
Member

🤔 it seems pnpm is a pickier than npm when running publish:

$ pnpm publish
 ERR_PNPM_GIT_NOT_UNCLEAN  Unclean working tree. Commit or stash changes first.

If you want to disable Git checks on publish, set the "git-checks" setting to "false", or run again with "--no-git-checks".

$ git status
On branch main
Your branch is up to date with 'origin/main'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	tst-npm/

nothing added to commit but untracked files present (use "git add" to track)

(though I might be on a possibly old release of pnpm, and this might have been a bug)

@paescuj
Copy link
Collaborator Author

paescuj commented Mar 28, 2023

🤔 it seems pnpm is a pickier than npm when running publish:

$ pnpm publish
 ERR_PNPM_GIT_NOT_UNCLEAN  Unclean working tree. Commit or stash changes first.

If you want to disable Git checks on publish, set the "git-checks" setting to "false", or run again with "--no-git-checks".

$ git status
On branch main
Your branch is up to date with 'origin/main'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	tst-npm/

nothing added to commit but untracked files present (use "git add" to track)

(though I might be on a possibly old release of pnpm, and this might have been a bug)

Hmm you mean because it's not really "unclean" since it's only an untracked file? In that case it might indeed be a bit pickier and also this might have been addressed in a newer pnpm release...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants