Fix formatting of mpf's when format type is missing#857
Merged
skirpichev merged 1 commit intompmath:masterfrom Sep 8, 2024
Merged
Fix formatting of mpf's when format type is missing#857skirpichev merged 1 commit intompmath:masterfrom
skirpichev merged 1 commit intompmath:masterfrom
Conversation
851fbc3 to
a8d4361
Compare
Collaborator
Author
|
Now on top of #859 |
3a1a50a to
7e8c49b
Compare
Collaborator
Author
|
See also python/cpython#123560 |
In this case it was incorrectly assumed, that this is an equivalent of 'g' formatting type. It's not: 1) when no precision is specified - it should be equal to repr_deps(prec) to represent the given value faithfully. 2) when fixed-point is used to format the result, it always includes at least one digit past the decimal point. Closes mpmath#856
7e8c49b to
0cb9c7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this case it was incorrectly assumed, that this is an equivalent of 'g' formatting type. It's not:
Closes #856