Skip to content

fix: override watchOptions.ignored if the modernjs internal value is regexp#3291

Merged
zhoushaw merged 3 commits intomainfrom
chore/remove-warn
Nov 29, 2024
Merged

fix: override watchOptions.ignored if the modernjs internal value is regexp#3291
zhoushaw merged 3 commits intomainfrom
chore/remove-warn

Conversation

@2heal1
Copy link
Copy Markdown
Member

@2heal1 2heal1 commented Nov 28, 2024 •
edited
Loading

Description

  • override watchOptions.ignored if the modernjs internal value is regexp
  • add **/@my-types/** to watchOptions.ignored if the value is string or string[]

Related Issue

web-infra-dev/rsbuild#4075

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 28, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 891b819

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@module-federation/modern-js Patch
@module-federation/runtime Patch
@module-federation/enhanced Patch
@module-federation/rspack Patch
@module-federation/webpack-bundler-runtime Patch
@module-federation/sdk Patch
@module-federation/runtime-tools Patch
@module-federation/managers Patch
@module-federation/manifest Patch
@module-federation/dts-plugin Patch
@module-federation/third-party-dts-extractor Patch
@module-federation/devtools Patch
@module-federation/bridge-react Patch
@module-federation/bridge-vue3 Patch
@module-federation/bridge-shared Patch
@module-federation/bridge-react-webpack-plugin Patch
@module-federation/retry-plugin Patch
@module-federation/data-prefetch Patch
@module-federation/rsbuild-plugin Patch
@module-federation/error-codes Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/storybook-addon Patch
@module-federation/modernjsapp Patch
@module-federation/esbuild Patch
@module-federation/utilities Patch
website-new Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Nov 28, 2024 •
edited
Loading

✅ Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 891b819
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/6749617fc3afc40008f4e8ac
😎 Deploy Preview https://deploy-preview-3291--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@2heal1 2heal1 changed the title chore: no auto add watchOptions.ignored fix: override watchOptions.ignored if the modernjs internal value is regexp Nov 29, 2024
@zhoushaw zhoushaw merged commit e10725f into main Nov 29, 2024
@zhoushaw zhoushaw deleted the chore/remove-warn branch November 29, 2024 06:44
@KyrieLii KyrieLii mentioned this pull request Nov 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhoushaw zhoushaw zhoushaw approved these changes

Assignees

No one assigned

Labels

change: fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@2heal1 @zhoushaw