fix: watchOptions.ignored use array glob instead of regexp#4075
Closed
fix: watchOptions.ignored use array glob instead of regexp#4075
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Merged
6 tasks
chenjiahan
reviewed
Nov 27, 2024
Member
chenjiahan
left a comment
There was a problem hiding this comment.
I actually used RegExp instead of array intentionally for several reasons:
- I prefer to allow users to "override" the default value rather than "merge with" the default value. Since some users may want to watch
node_modules, it should be easy for them to override the default behavior. - RegExp has better performance. When using glob patterns, Rspack will use glob-to-regexp to generate a complex RegExp, which may slow down the build.
Member
Author
|
gotcha , in fact i just need to modify webpack config , and i find the issue seems to be solved . Okay i will close this pr |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both Webpack and Rspack have the watchOptions.ignore type as
Regexp | string | string[], if the internal configuration is Regexp , it's difficult for users to expand this config, so recommend to use array instead.before
after
Checklist