[24.0 backport] Fix npe in exec resize when exec errored#45643
Merged
AkihiroSuda merged 1 commit intomoby:24.0from May 29, 2023
Merged
[24.0 backport] Fix npe in exec resize when exec errored#45643AkihiroSuda merged 1 commit intomoby:24.0from
AkihiroSuda merged 1 commit intomoby:24.0from
Conversation
In cases where an exec start failed the exec process will be nil even though the channel to signal that the exec started was closed. Ideally ExecConfig would get a nice refactor to handle this case better (ie. it's not started so don't close that channel). This is a minimal fix to prevent NPE. Luckilly this would only get called by a client and only the http request goroutine gets the panic (http lib recovers the panic). Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit 487ea81) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
cpuguy83
approved these changes
May 28, 2023
Member
Author
|
FWIW; I checked if this was needed for the 23.0 branch, but this looks to have been introduced in 4bafaa0#diff-706db5cf0385b14587b021d64bb7edf3ef1b35cf349e8368b1fdfeeeec573a87 (#43564), which is not part of the 23.0 branch. |
AkihiroSuda
approved these changes
May 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cases where an exec start failed the exec process will be nil even though the channel to signal that the exec started was closed.
Ideally ExecConfig would get a nice refactor to handle this case better (ie. it's not started so don't close that channel). This is a minimal fix to prevent NPE. Luckilly this would only get called by a client and only the http request goroutine gets the panic (http lib recovers the panic).
(cherry picked from commit 487ea81)
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)