Fix npe in exec resize when exec errored#45641
Merged
AkihiroSuda merged 1 commit intomoby:masterfrom May 28, 2023
Merged
Conversation
thaJeztah
approved these changes
May 27, 2023
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM, but left one suggestion
In cases where an exec start failed the exec process will be nil even though the channel to signal that the exec started was closed. Ideally ExecConfig would get a nice refactor to handle this case better (ie. it's not started so don't close that channel). This is a minimal fix to prevent NPE. Luckilly this would only get called by a client and only the http request goroutine gets the panic (http lib recovers the panic). Signed-off-by: Brian Goff <cpuguy83@gmail.com>
AkihiroSuda
approved these changes
May 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
In cases where an exec start failed the exec process will be nil even though the channel to signal that the exec started was closed.
Ideally ExecConfig would get a nice refactor to handle this case better (ie. it's not started so don't close that channel). This is a minimal fix to prevent NPE. Luckilly this would only get called by a client and only the http request goroutine gets the panic (http lib recovers the panic).
- How I did it
Add nil check to exec process
- How to verify it
Watch the daemon logs there will be (or potentially will be) a nil pointer exception.
Details
- Description for the changelog
Fix nil pointer exception in exec resize when exec command errored
- A picture of a cute animal (not mandatory but encouraged)
