Conversation
There was a problem hiding this comment.
Copilot reviewed 39 out of 54 changed files in this pull request and generated no comments.
Files not reviewed (15)
- crates/libs/registry/Cargo.toml: Evaluated as low risk
- crates/libs/strings/readme.md: Evaluated as low risk
- crates/libs/implement/Cargo.toml: Evaluated as low risk
- crates/libs/strings/Cargo.toml: Evaluated as low risk
- crates/libs/registry/readme.md: Evaluated as low risk
- crates/libs/result/Cargo.toml: Evaluated as low risk
- crates/libs/result/readme.md: Evaluated as low risk
- .github/workflows/lib.yml: Evaluated as low risk
- crates/libs/targets/src/lib.rs: Evaluated as low risk
- crates/libs/bindgen/Cargo.toml: Evaluated as low risk
- crates/libs/core/Cargo.toml: Evaluated as low risk
- crates/libs/interface/Cargo.toml: Evaluated as low risk
- crates/libs/targets/readme.md: Evaluated as low risk
- crates/libs/cppwinrt/Cargo.toml: Evaluated as low risk
- crates/libs/core/readme.md: Evaluated as low risk
Contributor
|
Did you mean to undo #2868 in the release commit? |
Collaborator
Author
|
Yes, 0.53 was a major update and no longer needed to carry this compatibility fix. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major crate updates:
windows0.59.0windows-core0.59.0windows-implement0.59.0windows-interface0.59.0windows-targets0.53.0windows_i686_msvc0.53.0windows_x86_64_msvc0.53.0windows_aarch64_msvc0.53.0windows_i686_gnu0.53.0windows_x86_64_gnu0.53.0windows_i686_gnullvm0.53.0windows_x86_64_gnullvm0.53.0windows_aarch64_gnullvm0.53.0windows-bindgen0.59.0windows-registry0.4.0windows-result0.3.0windows-strings0.3.0cppwinrt0.2.0Minor crate updates:
windows-version0.1.2Excluded:
windows-sys0.59.0Things to keep in mind:
The tag/release names no longer map directly to the crate versions, so to find samples for a particular release requires looking at the releases page and finding the release that most recently updated a particular crate.
The
windows-bindgencrate includes the major code generation overhaul that brings many improvements - be sure to check out the PR description for more information. The resulting code gen depends on the new version ofwindows-coreand its dependencies, unless you include the--sysoption. Majorwindows-bindgenupdate #3359The
cppwinrtcrate constitutes a major update due to streamlining the error handling.cppwinrtshould consistently panic on failure #3415The
windows-registry,windows-strings,andwindows-resultcrates are also major version updates since they include small breaking changes.The
windows-targetscrate finally receives a major version update, the first in over a year. This is due to Majorwindows-bindgenupdate #3359 and Update Windows metadata #3342 potentially introducing breaking changes. Although unlikely, these updates introduced sufficient changes that make it hard to ensure that thewindows-targetslibs don't break existing code. As we're updatingwindows-targetsanyway, I took the liberty to bump the MSRV to 1.60 - to match the latest version ofwindows-sys- and remove the old but unused doc macro feature. Both remained for compatibility with very old dependents of thewindows-targetscrate.The
windows-versioncrate receives a minor update to update its dependency on thewindows-targetscrate.Beyond these specifics, this update is the culmination of around 6 months worth of work on the
windows-rsproject. The biggest improvements comes from the new code generation engine, but many other improvements are now also available for production. This includes support for many new lints, warnings, and suggestions provided by the Rust toolchain; much smaller code gen thanks to deriving many more traits; more efficient code gen; major improvements to WinRT type system and implementation support; more robust and consistent error handling; stock collection and async support; improved support for class hierarchies; and much more!