cppwinrt should consistently panic on failure #3415
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- crates/tests/winrt/noexcept/build.rs: Evaluated as low risk
- crates/tests/winrt/ref_params/build.rs: Evaluated as low risk
Comments suppressed due to low confidence (2)
crates/libs/cppwinrt/src/lib.rs:32
- The panic message should provide more context. Consider changing it to
panic!("cppwinrt failed: {}", String::from_utf8_lossy(&output.stderr)).
panic!("{}", String::from_utf8_lossy(&output.stderr))
crates/libs/cppwinrt/src/lib.rs:42
- Ensure that the new behavior of panicking on failure is adequately covered by tests. The
invalid_argtest should cover this scenario.
fn invalid_arg() {
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings the
cppwinrtcrate in line with thewindows-bindgencrate that consistently panics on failure. As a build tool, this is simpler to consume and provides more reliable build failure information.