Skip to content

[Bug]: update snapshots not creating good diffs #34504

@debs-obrien

Description

@debs-obrien

Version

1.51.0-alpha-2025-01-22

Steps to reproduce

  1. create the follwing test:
test('test', async ({ page }) => {
  await page.goto('https://debs-obrien.github.io/playwright-movies-app/movie?id=533535&page=1');
  await expect(page.getByRole('main')).toMatchAriaSnapshot(``);
});
  1. run test using the play button in vscode extension

  2. run 'git apply test-results/rebaselines.patch'

  3. change the page source so snapshots will differ. This is done by modifying the movie id. The code snippet below shows a goto with a url containing a different id. Use this snippet or just manually edit the movie id to be 718821

test('test', async ({ page }) => {
  await page.goto('https://debs-obrien.github.io/playwright-movies-app/movie?id=718821&page=1');
  await expect(page.getByRole('main')).toMatchAriaSnapshot(``);
});
  1. run test again in vscode.
  2. run git apply test-results/rebaselines.patch

Expected behavior

should be good diff

Actual behavior

patch with only garbage at line 4

Additional context

Note running with --update-source-method 3-way is also not working so best way to see whats happening is to check diff in test results folder

Environment

System:
    OS: macOS 15.2
    CPU: (10) arm64 Apple M1 Max
    Memory: 236.09 MB / 64.00 GB
  Binaries:
    Node: 20.11.1 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.4 - /usr/local/bin/npm
    pnpm: 8.5.0 - /usr/local/bin/pnpm
  IDEs:
    VSCode: 1.96.4 - /usr/local/bin/code
  Languages:
    Bash: 3.2.57 - /bin/bash
  npmPackages:
    @playwright/test: ^1.51.0-alpha-2025-01-22 => 1.51.0-alpha-2025-01-22

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions