Skip to content

chore: allow repetative application of rebaselines in the same session#34524

Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:repeat_rebase
Jan 28, 2025
Merged

chore: allow repetative application of rebaselines in the same session#34524
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:repeat_rebase

Conversation

@pavelfeldman
Copy link
Copy Markdown
Member

@pavelfeldman pavelfeldman commented Jan 28, 2025

Fixes #34504

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 28, 2025

Test results for "tests 1"

1 failed
❌ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18

16 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsertype-connect.spec.ts:188:5 › launchServer › should be able to visit ipv6 through localhost @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/defaultbrowsercontext-2.spec.ts:28:3 › should work in persistent context @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:55:14 › page screenshot › should work with a mobile viewport and clip @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:428:5 › selector generator › should work without CSS.escape @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:453:1 › should have network request overrides 2 @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:756:1 › should handle multiple headers @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1601:1 › canvas disabled title @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1697:1 › should open settings dialog @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:868:5 › page screenshot animations › should wait for fonts to load @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37718 passed, 661 skipped
✔️✔️✔️

Merge workflow run.

@pavelfeldman pavelfeldman merged commit 7060cd1 into microsoft:main Jan 28, 2025
28 of 29 checks passed
pavelfeldman added a commit that referenced this pull request Jan 28, 2025
@pavelfeldman
cherry-pick(#34524): chore: allow repetative application of rebaselin…
50a58f9 
…es in the same session
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yury-s yury-s yury-s approved these changes

@dgozman dgozman dgozman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: update snapshots not creating good diffs

3 participants

@pavelfeldman @yury-s @dgozman