fix: Updated Input stories to show appearance and disabled#32176
Merged
GeoffCoxMSFT merged 6 commits intomicrosoft:masterfrom Aug 1, 2024
Merged
fix: Updated Input stories to show appearance and disabled#32176GeoffCoxMSFT merged 6 commits intomicrosoft:masterfrom
GeoffCoxMSFT merged 6 commits intomicrosoft:masterfrom
Conversation
Collaborator
📊 Bundle size report✅ No changes found |
spmonahan
approved these changes
Jul 31, 2024
packages/react-components/react-input/stories/src/Input/InputAppearance.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-input/stories/src/Input/InputAppearance.stories.tsx
Outdated
Show resolved
Hide resolved
GeoffCoxMSFT
commented
Jul 31, 2024
packages/react-components/react-input/stories/src/Input/InputDisabled.stories.tsx
Outdated
Show resolved
Hide resolved
…isabled.stories.tsx
smhigley
requested changes
Aug 1, 2024
Contributor
smhigley
left a comment
There was a problem hiding this comment.
The shadow appearances would need to be shown over a dark background, since on a light background they fail WCAG's non-text contrast criterion (the boundary must meet 3:1 contrast).
I think this is what was brought up in chat, but I think those might also be deprecated/not different from filled darker & lighter?
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 641 | 642 | 5000 | |
| Button | mount | 298 | 290 | 5000 | |
| Field | mount | 1106 | 1173 | 5000 | |
| FluentProvider | mount | 729 | 743 | 5000 | |
| FluentProviderWithTheme | mount | 82 | 87 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 34 | 39 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 74 | 85 | 10 | |
| MakeStyles | mount | 865 | 889 | 50000 | |
| Persona | mount | 1763 | 1743 | 5000 | |
| SpinButton | mount | 1371 | 1397 | 5000 | |
| SwatchPicker | mount | 1644 | 1642 | 5000 |
fabricteam
reviewed
Aug 1, 2024
smhigley
approved these changes
Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Related Issue(s)
Screenshots (after)