Revert "fix: Input should start with undefined, same as textarea"#30845
Merged
Revert "fix: Input should start with undefined, same as textarea"#30845
Conversation
)" This reverts commit 90b66ca.
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 56 | 61 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 636 | 635 | 5000 | |
| Button | mount | 306 | 301 | 5000 | |
| Field | mount | 1120 | 1161 | 5000 | |
| FluentProvider | mount | 698 | 696 | 5000 | |
| FluentProviderWithTheme | mount | 73 | 82 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 56 | 61 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 70 | 81 | 10 | |
| MakeStyles | mount | 851 | 863 | 50000 | |
| Persona | mount | 1740 | 1716 | 5000 | |
| SpinButton | mount | 1377 | 1349 | 5000 |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
spmonahan
approved these changes
Mar 21, 2024
spmonahan
approved these changes
Mar 21, 2024
Contributor
This does sound like the better alternative IMO 👀, maybe we should investigate in stopping controlling the native
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
robertpenner
pushed a commit
to robertpenner/fluentui
that referenced
this pull request
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #30534
The initial value of the input's controllable state is explicitly an empty string since we pass the
valuein to the native rendered<input />always. After the above PR an uncontrolledInputcomponent always renders a react warning because any user input will output this error in non-production environmentsThis is a blocking issue for any user who consumes this change and has test failures on console.error. Here's a screen recording
If an
undefinedvalue is necessary as an initial value then we should create an issue to track since the change in non-trivial. We always pass thevalueto intrinsicinputelements and that would need to change first.