fix: Input should start with undefined, same as textarea#30534
fix: Input should start with undefined, same as textarea#30534khmakoto merged 2 commits intomicrosoft:masterfrom
Conversation
@microsoft-github-policy-service agree |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
/azp run Fluent UI React - PR and CI |
|
/azp run Fluent UI React - Perf-Test |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 630 | 620 | 5000 | |
| Button | mount | 304 | 305 | 5000 | |
| Field | mount | 1149 | 1132 | 5000 | |
| FluentProvider | mount | 706 | 713 | 5000 | |
| FluentProviderWithTheme | mount | 89 | 88 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 77 | 73 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 80 | 85 | 10 | |
| MakeStyles | mount | 838 | 876 | 50000 | |
| Persona | mount | 1745 | 1711 | 5000 | |
| SpinButton | mount | 1387 | 1396 | 5000 |
)" This reverts commit 90b66ca.
Previous Behavior
InitialState of @fluentui/react-input is an empty string.
New Behavior
InitialState of @fluentui/react-input is undefined, same as textarea.
fluentui/packages/react-components/react-textarea/src/components/Textarea/useTextarea.ts
Line 43 in 1e10b26