Skip to content

Update protobuf version to latest#890

Merged
danditomaso merged 1 commit into
meshtastic:mainfrom
danditomaso:chore/update-protobuf-version
Oct 15, 2025
Merged

Update protobuf version to latest#890
danditomaso merged 1 commit into
meshtastic:mainfrom
danditomaso:chore/update-protobuf-version

Conversation

@danditomaso

Copy link
Copy Markdown
Collaborator

Description

This PR brings the protobuf package dependency to its latest available version.

Related Issues

Fixes #862

Changes Made

  • Updated root package json to latest JSR protobuf version

Testing Done

Started web client, opened all tabs. Found deprecated enum within Config page that had to be updated.

Screenshots (if applicable)

Checklist

  • Code follows project style guidelines
  • Documentation has been updated or added
  • Tests have been added or updated
  • All i18n translation labels have been added (read
    CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)

Copilot AI review requested due to automatic review settings October 15, 2025 13:16
@vercel

vercel Bot commented Oct 15, 2025

Copy link
Copy Markdown

@danditomaso is attempting to deploy a commit to the Meshtastic Team on Vercel.

A member of the Team first needs to authorize it.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the protobuf package dependency to the latest version and addresses a breaking change by using the new deprecated enum name for GPS coordinate format.

  • Updated @meshtastic/protobufs dependency from version 2.7.8 to 2.7.12-1
  • Replaced deprecated GpsCoordinateFormat enum with DeprecatedGpsCoordinateFormat to maintain compatibility

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
package.json Updated protobuf dependency to latest version
packages/web/src/validation/config/display.ts Updated enum reference to use deprecated variant after protobuf update
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@vercel

vercel Bot commented Oct 15, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
web-test Ready Ready Preview Comment Oct 15, 2025 1:27pm

@danditomaso danditomaso merged commit 34bdbe4 into meshtastic:main Oct 15, 2025
4 of 5 checks passed
@danditomaso danditomaso deleted the chore/update-protobuf-version branch October 15, 2025 14:23
danditomaso added a commit to danditomaso/meshtastic-web that referenced this pull request Oct 15, 2025
danditomaso added a commit that referenced this pull request Oct 16, 2025
* fix: show nodes on right sidebar on app load

* chore: update protobuf version to latest (#890)

* chore(deps-dev): bump happy-dom from 19.0.2 to 20.0.0 (#891)

Bumps [happy-dom](https://github.com/capricorn86/happy-dom) from 19.0.2 to 20.0.0.
- [Release notes](https://github.com/capricorn86/happy-dom/releases)
- [Commits](capricorn86/happy-dom@v19.0.2...v20.0.0)

---
updated-dependencies:
- dependency-name: happy-dom
  dependency-version: 20.0.0
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update packages/web/src/core/stores/nodeDBStore/index.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Clicking on a "CLIENT_BASE" node gives an error "Cannot read properties of undefined (reading 'replace')"

2 participants