Show nodes on right sidebar on app load#892
Merged
danditomaso merged 4 commits intoOct 16, 2025
Merged
Conversation
|
@danditomaso is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a rendering issue where nodes weren't displayed on the right sidebar until after navigating away and back to the Messages page. The fix removes unnecessary memoization that prevented re-renders when nodes loaded.
- Removed
useMemowrapper from therightSidebarcomponent to ensure it re-renders when nodes are loaded - Added CSS optimization using
contentVisibilityandcontainIntrinsicSizefor better scrolling performance - Updated
getMyNodereturn type to be non-nullable in the NodeDB interface
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/web/src/pages/Messages.tsx | Removed useMemo from rightSidebar to fix rendering issue and added CSS performance optimization |
| packages/web/src/core/stores/nodeDBStore/index.ts | Changed getMyNode return type from potentially undefined to always returning a NodeInfo object |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Bumps [happy-dom](https://github.com/capricorn86/happy-dom) from 19.0.2 to 20.0.0. - [Release notes](https://github.com/capricorn86/happy-dom/releases) - [Commits](capricorn86/happy-dom@v19.0.2...v20.0.0) --- updated-dependencies: - dependency-name: happy-dom dependency-version: 20.0.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a small issue where nodes weren't showing up after app load until the user navigated to another page, and back to the Messages page. This removes the memoization on the right navigation bar which was causing this issue not rerendering when the nodes load.
Related Issues
Changes Made
Checklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)