Restored user's node to ui (messages/node list)#878
Merged
danditomaso merged 3 commits intoOct 11, 2025
Conversation
|
@danditomaso is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restores the user's own node to the UI by making it visible in both the messages screen and node list. Previously, the user's connected node was hidden from these views.
- Changed node filtering to include the user's own node in both messages and nodes pages
- Added undefined check for improved TypeScript safety when accessing the current node
- Updated type signature to reflect that getMyNode may still return undefined in some cases
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/web/src/pages/Nodes/index.tsx | Enable inclusion of user's own node in the nodes list |
| packages/web/src/pages/Messages.tsx | Include user's own node in messages view and add safety check |
| packages/web/src/core/stores/nodeDBStore/index.ts | Update getMyNode return type signature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
3 tasks
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR restore the users own node to both the messages screen and the node list. There has been debate if it should be listed and this PR has determined going forwards all nodes including the node you are connected to will be visible in the UI.
Related Issues
Fixes #870
Changes Made
Testing Done
Opened the webUI and determined the node you are connected to is favouriated and and at the top of the list.
Checklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)