Added webp preset types and test for same. Issue 3747#3748
Merged
lovell merged 3 commits intolovell:mainfrom Aug 4, 2023
Merged
Added webp preset types and test for same. Issue 3747#3748lovell merged 3 commits intolovell:mainfrom
lovell merged 3 commits intolovell:mainfrom
Conversation
lovell
reviewed
Aug 2, 2023
Owner
lovell
left a comment
There was a problem hiding this comment.
Thank you very much for the PR, I've left one question inline.
Owner
Did you intend to include this as part of your PR? |
Contributor
Author
|
| The enum as sharp.preset on sharp. But having taken a closer look, the other exposed enums are there specifically because they are then exposed and overridden in an interface later. So this doesn't really seem necessary. I've removed it and pushed the code again. |
lovell
approved these changes
Aug 4, 2023
Owner
|
Thank you Seth! |
lovell
added a commit
that referenced
this pull request
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue #3747.
The webp output options type is missing the preset values in the types. They are present in the js library.
This PR adds:
PresetEnum)WebpOptionssharp.presetonsharp.webp({preset: ...})This follows the same implementation as other options, such as resize.fit.
npm test-types and npm test-lint both run cleanly.