Merged
Conversation
Owner
|
Thank you, this looks like a bug inherited from when the TypeScript definitions were imported from DefinitelyTyped. Are you able to add a test for this also, to help prevent regression? |
Contributor
Author
|
Already there is minSize test as If this change is bad commit, could you tell me an example in one of your test cases I can base myself on to respect your guidelines, if any...? |
lovell
approved these changes
Aug 9, 2023
Owner
lovell
left a comment
There was a problem hiding this comment.
Brilliant, thank you, the existing (inherited) test case was wrong so thanks for fixing this too!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While use sharp to convert to WebP with TypeScript, I found the Type Error of
WebpOptions.minSize.it param is boolean, but Type specify as number.
So we had going to use
@ts-ignorewhen use this option.This PR corrects this bug.