protoparse: fixes to issues reported in v1.15.0#554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a data race, caused by the fact that v1.15.0, under the hood, now uses protocompile, and protocompile as of v0.3.0 is possibly more susceptible to this issue. See bufbuild/protocompile#102.
It also addresses a regression -- an unintended change in behavior due to the use of protocompile regarding how custom options are represented in the returned descriptors. See #553.
Part of this fix is to upgrade to the latest version protocompile, which also brings over a version of descriptor.proto from protoc v22, which meant some updates to test data.