Data race in v0.3.0 #102
Description
Description
After upgrading to github.com/jhump/protoreflect to v1.15.0, my unit tests fail with -race, it's okay when I remove all t.Parallel() calls. After checking the dependencies, I downgrade github.com/bufbuild/protocompile from v0.3.0 to v0.2.1-0.20230123224550-da57cd758c2f, that's the version that github.com/jhump/protoreflect uses in the go.mod file. Then all the tests passed again.
The tests are simple, just parsing a simple proto file and constructing a new proto message. However, there are 2 tests that parse the same proto file
Env
- go1.20
- Mac M1
Expected
The tests pass without a race condition.
Actual
WARNING: DATA RACE
Read at 0x00c00023e4c8 by goroutine 30:
google.golang.org/protobuf/types/descriptorpb.(*FieldDescriptorProto).GetTypeName()
/runner/_work/my-project/vendor/google.golang.org/protobuf/types/descriptorpb/descriptor.pb.go:958 +0xe04
github.com/bufbuild/protocompile/linker.resolveFieldTypes()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/linker/resolve.go:365 +0xe20
github.com/bufbuild/protocompile/linker.(*result).resolveReferences.func1()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/linker/resolve.go:246 +0xad4
github.com/bufbuild/protocompile/walk.messageDescriptor()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/walk/walk.go:122 +0x159
github.com/bufbuild/protocompile/walk.DescriptorsEnterAndExit()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/walk/walk.go:70 +0xc5
github.com/bufbuild/protocompile/linker.(*result).resolveReferences()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/linker/resolve.go:200 +0x9a4
github.com/bufbuild/protocompile/linker.Link()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/linker/linker.go:84 +0x5d1
github.com/bufbuild/protocompile.(*task).link()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/compiler.go:565 +0x105
github.com/bufbuild/protocompile.(*task).asFile()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/compiler.go:505 +0x11b0
github.com/bufbuild/protocompile.(*executor).doCompile()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/compiler.go:358 +0x53e
github.com/bufbuild/protocompile.(*executor).compileLocked.func1()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/compiler.go:277 +0x10c
Previous write at 0x00c00023e4c8 by goroutine 32:
github.com/bufbuild/protocompile/linker.resolveFieldTypes()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/linker/resolve.go:406 +0x1dd9
github.com/bufbuild/protocompile/linker.(*result).resolveReferences.func1()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/linker/resolve.go:246 +0xad4
github.com/bufbuild/protocompile/walk.messageDescriptor()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/walk/walk.go:122 +0x159
github.com/bufbuild/protocompile/walk.DescriptorsEnterAndExit()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/walk/walk.go:70 +0xc5
github.com/bufbuild/protocompile/linker.(*result).resolveReferences()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/linker/resolve.go:200 +0x9a4
github.com/bufbuild/protocompile/linker.Link()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/linker/linker.go:84 +0x5d1
github.com/bufbuild/protocompile.(*task).link()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/compiler.go:565 +0x105
github.com/bufbuild/protocompile.(*task).asFile()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/compiler.go:505 +0x11b0
github.com/bufbuild/protocompile.(*executor).doCompile()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/compiler.go:358 +0x53e
github.com/bufbuild/protocompile.(*executor).compileLocked.func1()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/compiler.go:277 +0x10c
Goroutine 30 (running) created at:
github.com/bufbuild/protocompile.(*executor).compileLocked()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/compiler.go:259 +0x369
github.com/bufbuild/protocompile.(*executor).compile()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/compiler.go:244 +0xf8
github.com/bufbuild/protocompile.(*task).asFile()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/compiler.go:458 +0x96a
github.com/bufbuild/protocompile.(*executor).doCompile()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/compiler.go:358 +0x53e
github.com/bufbuild/protocompile.(*executor).compileLocked.func1()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/compiler.go:277 +0x10c
Goroutine 32 (running) created at:
github.com/bufbuild/protocompile.(*executor).compileLocked()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/compiler.go:259 +0x369
github.com/bufbuild/protocompile.(*executor).compile()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/compiler.go:244 +0xf8
github.com/bufbuild/protocompile.(*task).asFile()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/compiler.go:458 +0x96a
github.com/bufbuild/protocompile.(*executor).doCompile()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/compiler.go:358 +0x53e
github.com/bufbuild/protocompile.(*executor).compileLocked.func1()
/runner/_work/my-project/vendor/github.com/bufbuild/protocompile/compiler.go:277 +0x10c
==================