fix(hook-env): preserve PATH reordering done after activation by jdx · Pull Request #8190 · jdx/mise

jdx · 2026-02-16T21:46:18Z

Summary

hook-env always restored __MISE_ORIG_PATH order when reconstructing PATH, discarding any reordering done after activation
This broke scenarios where ~/.zlogin (runs after ~/.zshrc) moves a PATH entry to the front for priority
Now collects orig paths in their current order to preserve post-activation reordering, while still appending any missing orig paths as a safety net

Builds on the earlier fix in #7919 (commit 9e021af) which handled paths appended after activation but didn't handle reordering of existing orig paths.

Test plan

Added e2e/env/test_path_reorder_after_activate regression test
Verified test fails without the fix (mytool/bin pushed to position 5) and passes with it (stays at position 1)
Existing test_path_post_activate_append still passes
Existing test_path_interleaved_regression still passes
All 477 unit tests pass
All linting passes

🤖 Generated with Claude Code

Note

Medium Risk
Touches PATH-building logic in hook-env, which affects shell environments broadly; bugs could reorder/omit PATH entries and break command resolution across shells.

Overview
Fixes hook-env PATH reconstruction so it preserves the current ordering of entries that were present in __MISE_ORIG_PATH, instead of always restoring the original captured order; it still appends any missing original entries as a safety net.

Adds an E2E regression test (e2e/env/test_path_reorder_after_activate) that simulates post-activation PATH reordering and asserts hook-env does not undo it.

^{Written by Cursor Bugbot for commit 8eed0ce. This will update automatically on new commits. Configure here.}

hook-env always used __MISE_ORIG_PATH order when reconstructing PATH, discarding any reordering done after activation (e.g., by ~/.zlogin which runs after ~/.zshrc where mise activate is placed). Now collect orig paths in their current order to preserve post-activation reordering. Fixes #8188 Fixes #8168 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

gemini-code-assist · 2026-02-16T21:46:34Z

Summary of Changes

Hello @jdx, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in mise's hook-env mechanism that previously failed to maintain PATH modifications made by users after mise activate had run. By refining the PATH reconstruction logic, the system now accurately respects user-defined reordering of PATH entries, particularly those performed in later shell startup scripts, thereby enhancing environment consistency and user control.

Highlights

Preserved PATH Reordering: The hook-env functionality now correctly preserves PATH reordering that occurs after mise activate, addressing a previous issue where such changes were discarded.
Support for Post-Activation Scripts: This fix specifically supports scenarios where shell scripts like ~/.zlogin reorder PATH entries for priority, ensuring user-defined environment modifications are respected.
Enhanced PATH Reconstruction Logic: The hook-env logic was updated to collect original paths in their current order while also appending any original paths that might have been temporarily removed, providing a robust solution for PATH management.
New Regression Test: A new end-to-end test, e2e/env/test_path_reorder_after_activate, was added to prevent future regressions and validate the fix.

Changelog

e2e/env/test_path_reorder_after_activate
- Added a new end-to-end test to validate that PATH reordering after mise activate is correctly preserved.
src/cli/hook_env.rs
- Modified the hook-env implementation to collect original PATH entries in their current order and append any missing original paths, ensuring post-activation reordering is maintained.

Activity

The pull request was opened by jdx to fix issues related to PATH reordering after mise activate.
The author provided a detailed summary and test plan, including verification steps.
A new regression test was added and confirmed to fail without the fix and pass with it.
Existing relevant tests (test_path_post_activate_append, test_path_interleaved_regression) were verified to still pass.
All unit tests and linting checks passed.
The PR was generated using Claude Code.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request fixes an issue where hook-env would not preserve PATH reordering performed after shell activation. The changes in src/cli/hook_env.rs correctly reconstruct the PATH by respecting the current order of original path entries, which resolves the problem. A new end-to-end test has been added to verify this fix. The implementation looks solid. I have one suggestion to make the new test script more robust.

gemini-code-assist · 2026-02-16T21:48:28Z

e2e/env/test_path_reorder_after_activate

+MYTOOL_POS=$(echo "$PATH" | tr ':' '\n' | grep -n "mytool/bin" | head -1 | cut -d: -f1)
+SYSTEM_POS=$(echo "$PATH" | tr ':' '\n' | grep -n "system-bin" | head -1 | cut -d: -f1)


The grep commands here could lead to incorrect matches if other paths in PATH contain "mytool/bin" or "system-bin" as substrings. To make the test more robust, it's better to perform an exact match on the full path strings.

You can use grep -F -x for an exact, full-line match. Since the command is in double quotes, $HOME will be expanded correctly.

MYTOOL_POS=$(echo "$PATH" | tr ':' '\n' | grep -n -F -x "$HOME/mytool/bin" | head -1 | cut -d: -f1) SYSTEM_POS=$(echo "$PATH" | tr ':' '\n' | grep -n -F -x "$HOME/system-bin" | head -1 | cut -d: -f1)

Copilot

Pull request overview

Updates hook-env PATH reconstruction to preserve post-activation reordering of original PATH entries (e.g., changes made in ~/.zlogin after mise activate), fixing reported ordering regressions.

Changes:

Collects original PATH entries in their current order (instead of restoring __MISE_ORIG_PATH order), while appending any missing original entries as a safety net.
Adds an e2e regression test covering PATH reordering after activation.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`src/cli/hook_env.rs`	Adjusts PATH reconstruction to preserve reordered original PATH entries while keeping existing “pre”/“post_user” behavior.
`e2e/env/test_path_reorder_after_activate`	New regression test asserting that post-activation reordering of an original PATH entry is preserved.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-16T21:50:34Z

e2e/env/test_path_reorder_after_activate

+# and https://github.com/jdx/mise/issues/8168
+
+# Save the mise binary path before we override PATH
+MISE_BIN="$(which mise)"


which is non-POSIX and is flagged by ShellCheck (SC2230). Since hk.pkl runs shellcheck over e2e/**, this will break linting in CI. Prefer command -v mise (and fail with a clear message if it’s not found) when capturing the absolute path before overriding PATH.

Suggested change

MISE_BIN="$(which mise)"

MISE_BIN="$(command -v mise)"

if [[ -z "$MISE_BIN" ]]; then

echo "FAIL: mise binary not found in PATH" >&2

exit 1

fi

github-actions · 2026-02-16T22:03:29Z

Hyperfine Performance

`mise x -- echo`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2026.2.13 x -- echo`	24.4 ± 0.7	23.0	29.5	1.02 ± 0.04
`mise x -- echo`	23.9 ± 0.5	23.0	27.4	1.00

`mise env`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2026.2.13 env`	23.4 ± 0.6	22.5	29.5	1.00 ± 0.03
`mise env`	23.4 ± 0.4	22.6	25.1	1.00

`mise hook-env`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2026.2.13 hook-env`	23.9 ± 0.6	23.2	31.3	1.00
`mise hook-env`	24.0 ± 0.4	23.4	25.7	1.00 ± 0.03

`mise ls`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2026.2.13 ls`	22.1 ± 0.3	21.5	23.7	1.00
`mise ls`	22.3 ± 0.4	21.7	24.5	1.01 ± 0.02

`xtasks/test/perf`

Command	mise-2026.2.13	mise	Variance
install (cached)	127ms	127ms	+0%
ls (cached)	79ms	79ms	+0%
bin-paths (cached)	83ms	82ms	+1%
task-ls (cached)	829ms	825ms	+0%

@jdx

### 🚀 Features - **(task)** stream keep-order output in real-time per task by @jdx in [#8164](#8164) ### 🐛 Bug Fixes - **(aqua)** resolve lockfile artifacts for target platform (fix discussion #7479) by @mackwic in [#8183](#8183) - **(exec)** strip shims from PATH to prevent recursive shim execution by @jdx in [#8189](#8189) - **(hook-env)** preserve PATH reordering done after activation by @jdx in [#8190](#8190) - **(lockfile)** resolve version aliases before lockfile lookup by @jdx in [#8194](#8194) - **(registry)** set helm-diff archive bin name to diff by @jean-humann in [#8173](#8173) - **(task)** improve source freshness checks with dynamic task dirs by @rooperuu in [#8169](#8169) - **(task)** resolve global tasks when running from monorepo root by @jdx in [#8192](#8192) - **(task)** prevent wildcard glob `test:*` from matching parent task `test` by @jdx in [#8165](#8165) - **(task)** resolve task_config.includes relative to config root by @jdx in [#8193](#8193) - **(upgrade)** skip untrusted tracked configs during upgrade by @jdx in [#8195](#8195) ### 🚜 Refactor - use enum for npm.pacakge_manager by @risu729 in [#8180](#8180) ### 📚 Documentation - **(plugins)** replace node/asdf-nodejs examples with vfox plugins by @jdx in [#8191](#8191) ### ⚡ Performance - call npm view only once by @risu729 in [#8181](#8181) ### New Contributors - @jean-humann made their first contribution in [#8173](#8173) - @mackwic made their first contribution in [#8183](#8183) - @rooperuu made their first contribution in [#8169](#8169) ## 📦 Aqua Registry Updates #### New Packages (2) - [`BetterDiscord/cli`](https://github.com/BetterDiscord/cli) - [`glossia.ai/cli`](https://github.com/glossia.ai/cli)

## Summary - `hook-env` always restored `__MISE_ORIG_PATH` order when reconstructing PATH, discarding any reordering done after activation - This broke scenarios where `~/.zlogin` (runs after `~/.zshrc`) moves a PATH entry to the front for priority - Now collects orig paths in their current order to preserve post-activation reordering, while still appending any missing orig paths as a safety net Fixes jdx#8188 Fixes jdx#8168 Builds on the earlier fix in jdx#7919 (commit 9e021af) which handled paths *appended* after activation but didn't handle *reordering* of existing orig paths. ## Test plan - [x] Added `e2e/env/test_path_reorder_after_activate` regression test - [x] Verified test **fails** without the fix (mytool/bin pushed to position 5) and **passes** with it (stays at position 1) - [x] Existing `test_path_post_activate_append` still passes - [x] Existing `test_path_interleaved_regression` still passes - [x] All 477 unit tests pass - [x] All linting passes 🤖 Generated with [Claude Code](https://claude.com/claude-code)  --- > [!NOTE] > **Medium Risk** > Touches PATH-building logic in `hook-env`, which affects shell environments broadly; bugs could reorder/omit PATH entries and break command resolution across shells. > > **Overview** > Fixes `hook-env` PATH reconstruction so it preserves the *current ordering* of entries that were present in `__MISE_ORIG_PATH`, instead of always restoring the original captured order; it still appends any missing original entries as a safety net. > > Adds an E2E regression test (`e2e/env/test_path_reorder_after_activate`) that simulates post-activation PATH reordering and asserts `hook-env` does not undo it. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 8eed0ce. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup>  Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

@jdx

### 🚀 Features - **(task)** stream keep-order output in real-time per task by @jdx in [jdx#8164](jdx#8164) ### 🐛 Bug Fixes - **(aqua)** resolve lockfile artifacts for target platform (fix discussion jdx#7479) by @mackwic in [jdx#8183](jdx#8183) - **(exec)** strip shims from PATH to prevent recursive shim execution by @jdx in [jdx#8189](jdx#8189) - **(hook-env)** preserve PATH reordering done after activation by @jdx in [jdx#8190](jdx#8190) - **(lockfile)** resolve version aliases before lockfile lookup by @jdx in [jdx#8194](jdx#8194) - **(registry)** set helm-diff archive bin name to diff by @jean-humann in [jdx#8173](jdx#8173) - **(task)** improve source freshness checks with dynamic task dirs by @rooperuu in [jdx#8169](jdx#8169) - **(task)** resolve global tasks when running from monorepo root by @jdx in [jdx#8192](jdx#8192) - **(task)** prevent wildcard glob `test:*` from matching parent task `test` by @jdx in [jdx#8165](jdx#8165) - **(task)** resolve task_config.includes relative to config root by @jdx in [jdx#8193](jdx#8193) - **(upgrade)** skip untrusted tracked configs during upgrade by @jdx in [jdx#8195](jdx#8195) ### 🚜 Refactor - use enum for npm.pacakge_manager by @risu729 in [jdx#8180](jdx#8180) ### 📚 Documentation - **(plugins)** replace node/asdf-nodejs examples with vfox plugins by @jdx in [jdx#8191](jdx#8191) ### ⚡ Performance - call npm view only once by @risu729 in [jdx#8181](jdx#8181) ### New Contributors - @jean-humann made their first contribution in [jdx#8173](jdx#8173) - @mackwic made their first contribution in [jdx#8183](jdx#8183) - @rooperuu made their first contribution in [jdx#8169](jdx#8169) ## 📦 Aqua Registry Updates #### New Packages (2) - [`BetterDiscord/cli`](https://github.com/BetterDiscord/cli) - [`glossia.ai/cli`](https://github.com/glossia.ai/cli)

@jdx

### 🚀 Features - **(task)** stream keep-order output in real-time per task by @jdx in [jdx#8164](jdx#8164) ### 🐛 Bug Fixes - **(aqua)** resolve lockfile artifacts for target platform (fix discussion jdx#7479) by @mackwic in [jdx#8183](jdx#8183) - **(exec)** strip shims from PATH to prevent recursive shim execution by @jdx in [jdx#8189](jdx#8189) - **(hook-env)** preserve PATH reordering done after activation by @jdx in [jdx#8190](jdx#8190) - **(lockfile)** resolve version aliases before lockfile lookup by @jdx in [jdx#8194](jdx#8194) - **(registry)** set helm-diff archive bin name to diff by @jean-humann in [jdx#8173](jdx#8173) - **(task)** improve source freshness checks with dynamic task dirs by @rooperuu in [jdx#8169](jdx#8169) - **(task)** resolve global tasks when running from monorepo root by @jdx in [jdx#8192](jdx#8192) - **(task)** prevent wildcard glob `test:*` from matching parent task `test` by @jdx in [jdx#8165](jdx#8165) - **(task)** resolve task_config.includes relative to config root by @jdx in [jdx#8193](jdx#8193) - **(upgrade)** skip untrusted tracked configs during upgrade by @jdx in [jdx#8195](jdx#8195) ### 🚜 Refactor - use enum for npm.pacakge_manager by @risu729 in [jdx#8180](jdx#8180) ### 📚 Documentation - **(plugins)** replace node/asdf-nodejs examples with vfox plugins by @jdx in [jdx#8191](jdx#8191) ### ⚡ Performance - call npm view only once by @risu729 in [jdx#8181](jdx#8181) ### New Contributors - @jean-humann made their first contribution in [jdx#8173](jdx#8173) - @mackwic made their first contribution in [jdx#8183](jdx#8183) - @rooperuu made their first contribution in [jdx#8169](jdx#8169) ## 📦 Aqua Registry Updates #### New Packages (2) - [`BetterDiscord/cli`](https://github.com/BetterDiscord/cli) - [`glossia.ai/cli`](https://github.com/glossia.ai/cli)

Copilot AI review requested due to automatic review settings February 16, 2026 21:46

Copilot started reviewing on behalf of jdx February 16, 2026 21:46 View session

gemini-code-assist bot reviewed Feb 16, 2026

View reviewed changes

Copilot AI reviewed Feb 16, 2026

View reviewed changes

jdx merged commit 4e30d61 into main Feb 16, 2026
43 checks passed

jdx deleted the fix/hook-env-preserve-path-reorder branch February 16, 2026 22:02

mise-en-dev mentioned this pull request Feb 16, 2026

chore: release 2026.2.15 #8177

Merged

BrewTestBot mentioned this pull request Feb 17, 2026

mise 2026.2.15 Homebrew/homebrew-core#267924

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(hook-env): preserve PATH reordering done after activation#8190

fix(hook-env): preserve PATH reordering done after activation#8190
jdx merged 1 commit intomainfrom
fix/hook-env-preserve-path-reorder

jdx commented Feb 16, 2026 •

edited by cursor bot

Loading

Uh oh!

gemini-code-assist bot commented Feb 16, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Feb 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 16, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		MYTOOL_POS=$(echo "$PATH" \| tr ':' '\n' \| grep -n "mytool/bin" \| head -1 \| cut -d: -f1)
		SYSTEM_POS=$(echo "$PATH" \| tr ':' '\n' \| grep -n "system-bin" \| head -1 \| cut -d: -f1)

-MISE_BIN="$(which mise)"
+MISE_BIN="$(command -v mise)"
+if [[ -z "$MISE_BIN" ]]; then
+	echo "FAIL: mise binary not found in PATH" >&2
+	exit 1
+fi

Uh oh!

Conversation

jdx commented Feb 16, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

gemini-code-assist bot commented Feb 16, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 16, 2026

Hyperfine Performance

mise x -- echo

mise env

mise hook-env

mise ls

xtasks/test/perf

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jdx commented Feb 16, 2026 •

edited by cursor bot

Loading

`mise x -- echo`

`mise env`

`mise hook-env`

`mise ls`

`xtasks/test/perf`