feat(react, vue, angular): use tabs without router #29794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-authored-by: Sean Perkins <13732623+sean-perkins@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
approved these changes
Aug 23, 2024
rugoncalves
pushed a commit
that referenced
this pull request
Sep 5, 2024
Issue number: resolves #25184 --------- Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com> Co-authored-by: Sean Perkins <13732623+sean-perkins@users.noreply.github.com>
brandyscarney
added a commit
that referenced
this pull request
Sep 5, 2024
Issue number: resolves #25184 --------- Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com> Co-authored-by: Sean Perkins <13732623+sean-perkins@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #25184
What is the current behavior?
React: Developers have to provide
IonRouterOutletto useIonTabs. This means that developers are forced to tie their tabs to a router.Vue: Developers have to provide
ion-router-outletto useion-tabs. This means that developers are forced to tie their tabs to a router.Angular: Developers are defaulted to have
ion-router-outletwhenion-tabsis in their app. This means that developers are forced to tie their tabs to a router.What is the new behavior?
PRs were opened individually to make the changes
React
IonTabscan be used without a router outlet as long asIonTabis a child andIonRouterOutletis not./tabs-basicVue
ion-tabscan be used without a router outlet as long asion-tabis a child andion-router-outletis not./tabs-basicAngular
ion-tabscan be used without a router outlet as long asion-tabis a child./tabs-basicDoes this introduce a breaking change?
Developers who are still using
ion-tabswithion-router-outletwill not experience any changes. This feature PR introduces another option to useion-tabs, no changes for the current implementation.Other information
Dev build: 8.2.8-dev.11724440750.150ba143