feat(react): use tabs without router #29772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I think i can do a vue PR for this. What do you think? |
Contributor
Author
|
@dev-charles15531 We greatly appreciate the offer! However, we will be working on the Vue portion very soon. I would recommend looking through the other existing issues. There are some related to router if you're interested in those. |
|
Okay, thank you! |
BenOsodrac
approved these changes
Aug 20, 2024
sean-perkins
approved these changes
Aug 20, 2024
Contributor
sean-perkins
left a comment
There was a problem hiding this comment.
Woo, nice work on this!
brandyscarney
approved these changes
Aug 22, 2024
Member
brandyscarney
left a comment
There was a problem hiding this comment.
Tested the latest dev build in:
- A new React tabs starter app
- A new React tabs starter app with
IonRouterOutletremoved andIonTabcomponents containing only text content - The Ionic React Conference App
Everything is working correctly. Great job on this! 🎉
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: part of #25184
This PR does not completely close the issue since it only addresses the React portion. The other frameworks will be done through other PRs.
What is the current behavior?
React: Developers have to provide
IonRouterOutletto useIonTabs. This means that developers are forced to tie their tabs to a router.What is the new behavior?
IonTabscan be used without a router outlet as long asIonTabis a child andIonRouterOutletis not./tabs-basicDoes this introduce a breaking change?
Developers who are still using
IonTabswithIonRouterOutletwill not experience any changes. This feature PR introduces another option to useIonTabs, no changes for the current implementation.Other information
Dev build: 8.2.8-dev.11724280606.1a8c11d4