Reply to SETUP_TRANSPORT post-BinderServer shutdown#11260
Merged
jdcormie merged 15 commits intogrpc:masterfrom Jun 6, 2024
Merged
Reply to SETUP_TRANSPORT post-BinderServer shutdown#11260jdcormie merged 15 commits intogrpc:masterfrom
jdcormie merged 15 commits intogrpc:masterfrom
Conversation
mateusazis
reviewed
Jun 4, 2024
binder/src/androidTest/java/io/grpc/binder/internal/LeakSafeOneWayBinderTest.java
Outdated
Show resolved
Hide resolved
binder/src/androidTest/java/io/grpc/binder/internal/LeakSafeOneWayBinderTest.java
Show resolved
Hide resolved
binder/src/androidTest/java/io/grpc/binder/internal/LeakSafeOneWayBinderTest.java
Show resolved
Hide resolved
binder/src/androidTest/java/io/grpc/binder/internal/LeakSafeOneWayBinderTest.java
Show resolved
Hide resolved
binder/src/androidTest/java/io/grpc/binder/internal/LeakSafeOneWayBinderTest.java
Outdated
Show resolved
Hide resolved
mateusazis
approved these changes
Jun 4, 2024
mateusazis
reviewed
Jun 5, 2024
temawi
approved these changes
Jun 6, 2024
Contributor
|
Note the test failure. |
Member
Author
|
Contributor
You were right, I restarted the tests and we are all green now. |
larry-safran
pushed a commit
to larry-safran/grpc-java
that referenced
this pull request
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8931