Skip to content

Reply to SETUP_TRANSPORT post-BinderServer shutdown #11260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jdcormie merged 15 commits into from
Jun 6, 2024
Merged

Reply to SETUP_TRANSPORT post-BinderServer shutdown #11260

jdcormie merged 15 commits into from
Jun 6, 2024

Conversation

@jdcormie
Copy link
Member

@jdcormie jdcormie commented Jun 4, 2024

Fixes #8931

@jdcormie jdcormie requested a review from temawi June 4, 2024 20:18
mateusazis
mateusazis reviewed Jun 4, 2024
View reviewed changes
@jdcormie jdcormie requested a review from mateusazis June 4, 2024 22:00
@jdcormie jdcormie requested a review from mateusazis June 5, 2024 00:07
mateusazis
mateusazis reviewed Jun 5, 2024
View reviewed changes
@jdcormie jdcormie added the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Jun 5, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Jun 5, 2024
@jdcormie jdcormie added the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Jun 5, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Jun 5, 2024
@temawi
Copy link
Contributor

temawi commented Jun 6, 2024

Note the test failure.

@jdcormie
Copy link
Member Author

jdcormie commented Jun 6, 2024

Note the test failure.

io.grpc.internal.RetriableStreamTest > hedging_deadlock FAILED
Looks like a flake to me, since this PR doesn't change anything about grpc-core. LMK if I'm missing something.

@temawi
Copy link
Contributor

temawi commented Jun 6, 2024

Note the test failure.

io.grpc.internal.RetriableStreamTest > hedging_deadlock FAILED Looks like a flake to me, since this PR doesn't change anything about grpc-core. LMK if I'm missing something.

You were right, I restarted the tests and we are all green now.

@jdcormie jdcormie merged commit 1670e97 into grpc:master Jun 6, 2024
@jdcormie jdcormie deleted the goaway branch June 6, 2024 21:19
@jdcormie jdcormie mentioned this pull request Jun 6, 2024
Merged
@mateusazis mateusazis mentioned this pull request Jun 6, 2024
Closed
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Aug 13, 2024
@jdcormie @larry-safran
Reject further SETUP_TRANSPORT requests post-BinderServer shutdown (g…
78c3a81 
…rpc#11260)

Fixes grpc#8931
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@temawi temawi temawi approved these changes

+1 more reviewer

@mateusazis mateusazis mateusazis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

binder: Cross-process calls against a shutdown() Server do not fail fast as required by AbstractTransportTest

4 participants

@jdcormie @temawi @mateusazis @grpc-kokoro