[Fix][Compiler] Plugins fall back to the edition 2023 for older protobuf#41357
Closed
sergiitk wants to merge 1 commit intogrpc:masterfrom
Closed
[Fix][Compiler] Plugins fall back to the edition 2023 for older protobuf#41357sergiitk wants to merge 1 commit intogrpc:masterfrom
sergiitk wants to merge 1 commit intogrpc:masterfrom
Conversation
Fixes the issue with gRPC protobuf plugins declaring the support for `protobuf::Edition::EDITION_2024`, which is higher than the one supported by the protobuf we're using at the moment: `EDITION_2023` at protocolbuffers/protobuf@74211c0.
Member
Author
|
Confirming grpc python generator from this PR's artifacts works. $ python -m grpc_tools.protoc -I src/python/grpcio_health_checking/grpc_health --python_out=. --pyi_out=. --grpc_python_out=. src/python/grpcio_health_checking/grpc_health/v1/health.proto
$ tree -h v1
[ 160] v1/
├── [5.9K] health_pb2_grpc.py
├── [2.4K] health_pb2.py
└── [1.3K] health_pb2.pyi
1 directory, 3 files
$ pip list
Package Version
----------------- -----------
grpcio 1.79.0.dev0
grpcio-tools 1.79.0.dev0
pip 25.3
protobuf 6.33.2
setuptools 80.9.0
typing_extensions 4.15.0 |
markdroth
approved these changes
Jan 7, 2026
sergiitk
added a commit
that referenced
this pull request
Jan 8, 2026
…023 for older protobuf (#41358) Backport of #41357 to v1.78.x. --- Fixes the issue with gRPC protobuf plugins declaring the support for `protobuf::Edition::EDITION_2024`, which is higher than the one supported by the protobuf we're using at the moment: `EDITION_2023` at protocolbuffers/protobuf@74211c0. Related: - Effectively undoes #40957
asheshvidyut
added a commit
to asheshvidyut/grpc
that referenced
this pull request
Jan 9, 2026
…er protobuf (grpc#41357)" This reverts commit 9b77c0d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue with gRPC protobuf plugins declaring the support for
protobuf::Edition::EDITION_2024, which is higher than the one supported by the protobuf we're using at the moment:EDITION_2023at protocolbuffers/protobuf@74211c0.Related: