Skip to content

[Backport][v1.78.x][Fix][Compiler] Plugins fall back to the edition 2023 for older protobuf#41358

Merged
sergiitk merged 1 commit intogrpc:v1.78.xfrom
sergiitk:backport-1.78-fix/compiler/protobuf-edition-2023
Jan 8, 2026
Merged

[Backport][v1.78.x][Fix][Compiler] Plugins fall back to the edition 2023 for older protobuf#41358
sergiitk merged 1 commit intogrpc:v1.78.xfrom
sergiitk:backport-1.78-fix/compiler/protobuf-edition-2023

Conversation

@sergiitk
Copy link
Member

@sergiitk sergiitk commented Jan 7, 2026

Backport of #41357 to v1.78.x.

Fixes the issue with gRPC protobuf plugins declaring the support for protobuf::Edition::EDITION_2024, which is higher than the one supported by the protobuf we're using at the moment: EDITION_2023 at protocolbuffers/protobuf@74211c0.

Related:

Fixes the issue with gRPC protobuf plugins declaring the support for
`protobuf::Edition::EDITION_2024`, which is higher than the one
supported by the protobuf we're using at the moment: `EDITION_2023` at
protocolbuffers/protobuf@74211c0.
@sergiitk sergiitk self-assigned this Jan 7, 2026
@sergiitk sergiitk added disposition/DO NOT MERGE release notes: yes Indicates if PR needs to be in release notes labels Jan 7, 2026
@sergiitk sergiitk marked this pull request as ready for review January 7, 2026 21:23
@sergiitk sergiitk requested a review from murgatroid99 January 7, 2026 21:23
@sergiitk
Copy link
Member Author

sergiitk commented Jan 8, 2026

Double-checked the fix, all as expected:

$ python -m grpc_tools.protoc -I src/python/grpcio_health_checking/grpc_health --python_out=. --pyi_out=. --grpc_python_out=. src/python/grpcio_health_checking/grpc_health/v1/health.proto

$ tree -h v1
[ 160]  v1/
├── [5.9K]  health_pb2_grpc.py
├── [2.4K]  health_pb2.py
└── [1.3K]  health_pb2.pyi

@sergiitk sergiitk merged commit ea1d162 into grpc:v1.78.x Jan 8, 2026
57 of 59 checks passed
@sergiitk sergiitk deleted the backport-1.78-fix/compiler/protobuf-edition-2023 branch January 8, 2026 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants