fix: [#405] The GetAttribute of orm event returns an error value when getting id#478
Merged
fix: [#405] The GetAttribute of orm event returns an error value when getting id#478
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.13.x #478 +/- ##
============================================
- Coverage 62.24% 45.15% -17.10%
============================================
Files 125 232 +107
Lines 8078 17326 +9248
============================================
+ Hits 5028 7823 +2795
- Misses 2717 8954 +6237
- Partials 333 549 +216 ☔ View full report in Codecov by Sentry. |
hwbrzzl
pushed a commit
that referenced
this pull request
Mar 20, 2025
* Extract Guard interface and create jwt_guard * chore: update mocks * Fix unit test case methods * chore: update mocks * Fix a lint error * Add user provider and custom guards * chore: update mocks * Create default guard while creating AuthManager * Fix unit test suite case methods * chore: update mocks * Fix linter and unit test errors * Cleanup and add more test case methods * Fix linter issues * Add unit test case methods to extend Guard and UserProvider * Code cleanup based on the PR review feedback * Use mockauth.MockUserProvider * Fix Unit test case failures * Add no of EXPECTs for the mockconfig * Fix couple more mockconfig expects * Cleanup unnecessary JwtGuard type check and assertions * Rearrange methods in asc order * Revert back the Guard interface's Refresh and LoginInUsingID methods * Fix a typo * chore: update mocks * Move custom errors to errors/list.go * Cleanup jwt_guard parsing guard and authToken * Fix unit test case errors * Fix foundation application_test * User UserProvider to retrive the ID from the user model * Rename Guard to GuardDriver and retain the signature to support backward compatibility * Revert back the Refresh func * Cleanup * Cleanup * Cleanup * Split Auth and JWT Guard tests into its own file * Cleanup unnecessary type checks * Cleanup * Move jwt_guard_test back to auth_test --------- Co-authored-by: praem90 <6235720+praem90@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes goravel/goravel#405
📑 Description
✅ Checks
ℹ Additional Information