Skip to content

feat: add InRandomOrder method#405

Merged
hwbrzzl merged 8 commits intogoravel:masterfrom
Kamandlou:InRandomOrder
Feb 4, 2024
Merged

feat: add InRandomOrder method#405
hwbrzzl merged 8 commits intogoravel:masterfrom
Kamandlou:InRandomOrder

Conversation

@Kamandlou
Copy link
Contributor

@Kamandlou Kamandlou commented Feb 1, 2024

📑 Description

add InRandomOrder method

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@codecov
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c33b6e) 70.60% compared to head (71235c6) 70.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   70.60%   70.66%   +0.06%     
==========================================
  Files         152      152              
  Lines        9067     9079      +12     
==========================================
+ Hits         6402     6416      +14     
+ Misses       2159     2157       -2     
  Partials      506      506              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kamandlou Kamandlou requested a review from hwbrzzl February 3, 2024 11:41
@Kamandlou Kamandlou requested a review from hwbrzzl February 3, 2024 16:15
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@hwbrzzl hwbrzzl merged commit 6add0f2 into goravel:master Feb 4, 2024
@Kamandlou Kamandlou deleted the InRandomOrder branch February 4, 2024 08:17
hwbrzzl added a commit that referenced this pull request May 16, 2024
hwbrzzl added a commit that referenced this pull request May 19, 2024
… getting id (#478)

* fix: [#405] The GetAttribute of orm event returns an error value when getting id

* fix unit test

* optimize lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants