fix(oracle): enable DML operations and resolve incorrect array type error by ishatilwani1301 · Pull Request #2323 · googleapis/mcp-toolbox

ishatilwani1301 · 2026-01-16T06:56:35Z

This pull request resolves an issue where executing DML statements (UPDATE, INSERT, DELETE) caused "incorrect array type" errors. Previously, the Oracle source forced all operations to use QueryContext, expecting rows to be returned. This caused failures when running write operations that do not return rows.

Changes Implemented:
The modification updates the Oracle source and tool definitions to distinguish between Read-Only (SELECT) and Action (DML) operations.

internal/sources/oracle/oracle.go:

Updated RunSQL signature to accept a readOnly boolean.
Added conditional logic: If readOnly is false, it now uses ExecContext and returns rows_affected instead of attempting to scan non-existent rows.

internal/tools/oracle/oraclesql/oraclesql.go:

Added a readonly field to the tool configuration (YAML).
Updated the Invoke method to pass this flag to the source. Defaults to true (Read-Only) for backward compatibility.

internal/tools/oracle/oraclesql/oraclesql_test.go:

Added unit tests to verify that readonly: false is correctly parsed from the YAML configuration.

🛠️ Fixes #2026

gemini-code-assist · 2026-01-16T06:56:53Z

Summary of Changes

Hello @ishatilwani1301, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Oracle source's capabilities by enabling proper execution of Data Manipulation Language (DML) operations. Previously, all SQL statements were treated as queries, leading to errors when attempting to perform updates, inserts, or deletes. The changes introduce a mechanism to differentiate between read-only and action-based SQL, allowing DML statements to be processed correctly and report the number of affected rows, thereby expanding the utility of the Oracle integration.

Highlights

DML Operations Enabled: The Oracle source now correctly handles DML statements (INSERT, UPDATE, DELETE) by using ExecContext instead of QueryContext, resolving "incorrect array type" errors.
Read-Only Flag Introduced: A readOnly boolean parameter has been added to the RunSQL function in the Oracle source, and a corresponding readonly field is now available in the Oracle SQL tool configuration (YAML).
Configurable Operation Type: Tools can now explicitly define whether their SQL statement is read-only or an action (DML), with true (read-only) as the default for backward compatibility.
Improved DML Response: DML operations now return a structured response indicating "status" and "rows_affected" instead of attempting to scan non-existent rows.
Unit Test Coverage: New unit tests ensure that the readonly: false configuration for DML operations is correctly parsed and applied.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request effectively resolves the issue with DML statements by introducing a readOnly flag. The logic is sound, and the changes are well-contained. The addition of a unit test to cover the new configuration path is also a great practice. I've added one comment regarding code formatting. Additionally, I noticed some debugging fmt.Printf statements in internal/tools/oracle/oraclesql/oraclesql.go that were not part of the changed lines but should probably be removed before merging.

duwenxin99

We should also update the documentation to reflect this change. If the coverage is failing, we should look into how to raise the coverage. 20% is not a very high threshold.

duwenxin99

The implementation looks good, but we need to add integration test cases and update oracle-sql tool docs to reflect this change.

…y type error (#2323) This pull request resolves an issue where executing DML statements (UPDATE, INSERT, DELETE) caused "incorrect array type" errors. Previously, the Oracle source forced all operations to use QueryContext, expecting rows to be returned. This caused failures when running write operations that do not return rows. **Changes Implemented:** The modification updates the Oracle source and tool definitions to distinguish between Read-Only (SELECT) and Action (DML) operations. - **internal/sources/oracle/oracle.go:** 1. Updated RunSQL signature to accept a readOnly boolean. 2. Added conditional logic: If readOnly is false, it now uses ExecContext and returns rows_affected instead of attempting to scan non-existent rows. - **internal/tools/oracle/oraclesql/oraclesql.go:** 1. Added a readonly field to the tool configuration (YAML). 2. Updated the Invoke method to pass this flag to the source. Defaults to true (Read-Only) for backward compatibility. 🛠️ Fixes #2026 --------- Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com> 72146a4

…y type error (googleapis#2323) This pull request resolves an issue where executing DML statements (UPDATE, INSERT, DELETE) caused "incorrect array type" errors. Previously, the Oracle source forced all operations to use QueryContext, expecting rows to be returned. This caused failures when running write operations that do not return rows. **Changes Implemented:** The modification updates the Oracle source and tool definitions to distinguish between Read-Only (SELECT) and Action (DML) operations. - **internal/sources/oracle/oracle.go:** 1. Updated RunSQL signature to accept a readOnly boolean. 2. Added conditional logic: If readOnly is false, it now uses ExecContext and returns rows_affected instead of attempting to scan non-existent rows. - **internal/tools/oracle/oraclesql/oraclesql.go:** 1. Added a readonly field to the tool configuration (YAML). 2. Updated the Invoke method to pass this flag to the source. Defaults to true (Read-Only) for backward compatibility. 🛠️ Fixes googleapis#2026 --------- Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com> 72146a4

🤖 I have created a release *beep* *boop* --- ## [0.28.0](v0.27.0...v0.28.0) (2026-03-02) ### Features * Add polling system to dynamic reloading ([#2466](#2466)) ([fcaac9b](fcaac9b)) * Added basic template for sdks doc migrate ([#1961](#1961)) ([87f2eaf](87f2eaf)) * **dataproc:** Add dataproc source and list/get clusters/jobs tools ([#2407](#2407)) ([cc05e57](cc05e57)) * **sources/postgres:** Add configurable pgx query execution mode ([#2477](#2477)) ([57b77bc](57b77bc)) * **sources/redis:** Add TLS support for Redis connections ([#2432](#2432)) ([d6af290](d6af290)) * **tools/looker:** Enable Get All Lookml Tests, Run LookML Tests, and Create View From Table tools for Looker ([#2522](#2522)) ([e01139a](e01139a)) * **tools/looker:** Tools to list/create/delete directories ([#2488](#2488)) ([0036d8c](0036d8c)) * **ui:** Make tool list panel resizable ([#2253](#2253)) ([276cf60](276cf60)) ### Bug Fixes * **ci:** Add path for forked PR unit test runs ([#2540](#2540)) ([04dd2a7](04dd2a7)) * Deflake alloydb omni ([#2431](#2431)) ([62b8309](62b8309)) * **docs/adk:** Resolve dependency duplication ([#2418](#2418)) ([4d44abb](4d44abb)) * **docs/langchain:** Fix core at 0.3.0 and align compatible dependencies ([#2426](#2426)) ([36edfd3](36edfd3)) * Enforce required validation for explicit null parameter values ([#2519](#2519)) ([d5e9512](d5e9512)) * **oracle:** Enable DML operations and resolve incorrect array type error ([#2323](#2323)) ([72146a4](72146a4)) * **server/mcp:** Guard nil dereference in sseManager.get ([#2557](#2557)) ([e534196](e534196)), closes [#2548](#2548) * **tests/postgres:** Implement uuid-based isolation and reliable resource cleanup ([#2377](#2377)) ([8a96fb1](8a96fb1)) * **tests/postgres:** Restore list_schemas test and implement dynamic owner ([#2521](#2521)) ([7041e79](7041e79)) * **tests:** Resolve LlamaIndex dependency conflict in JS quickstart ([#2597](#2597)) ([ac11f5a](ac11f5a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [0.28.0](v0.27.0...v0.28.0) (2026-03-02) ### Features * Add polling system to dynamic reloading ([#2466](#2466)) ([fcaac9b](fcaac9b)) * Added basic template for sdks doc migrate ([#1961](#1961)) ([87f2eaf](87f2eaf)) * **dataproc:** Add dataproc source and list/get clusters/jobs tools ([#2407](#2407)) ([cc05e57](cc05e57)) * **sources/postgres:** Add configurable pgx query execution mode ([#2477](#2477)) ([57b77bc](57b77bc)) * **sources/redis:** Add TLS support for Redis connections ([#2432](#2432)) ([d6af290](d6af290)) * **tools/looker:** Enable Get All Lookml Tests, Run LookML Tests, and Create View From Table tools for Looker ([#2522](#2522)) ([e01139a](e01139a)) * **tools/looker:** Tools to list/create/delete directories ([#2488](#2488)) ([0036d8c](0036d8c)) * **ui:** Make tool list panel resizable ([#2253](#2253)) ([276cf60](276cf60)) ### Bug Fixes * **ci:** Add path for forked PR unit test runs ([#2540](#2540)) ([04dd2a7](04dd2a7)) * Deflake alloydb omni ([#2431](#2431)) ([62b8309](62b8309)) * **docs/adk:** Resolve dependency duplication ([#2418](#2418)) ([4d44abb](4d44abb)) * **docs/langchain:** Fix core at 0.3.0 and align compatible dependencies ([#2426](#2426)) ([36edfd3](36edfd3)) * Enforce required validation for explicit null parameter values ([#2519](#2519)) ([d5e9512](d5e9512)) * **oracle:** Enable DML operations and resolve incorrect array type error ([#2323](#2323)) ([72146a4](72146a4)) * **server/mcp:** Guard nil dereference in sseManager.get ([#2557](#2557)) ([e534196](e534196)), closes [#2548](#2548) * **tests/postgres:** Implement uuid-based isolation and reliable resource cleanup ([#2377](#2377)) ([8a96fb1](8a96fb1)) * **tests/postgres:** Restore list_schemas test and implement dynamic owner ([#2521](#2521)) ([7041e79](7041e79)) * **tests:** Resolve LlamaIndex dependency conflict in JS quickstart ([#2597](#2597)) ([ac11f5a](ac11f5a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com> 81253a0

🤖 I have created a release *beep* *boop* --- ## [0.28.0](googleapis/mcp-toolbox@v0.27.0...v0.28.0) (2026-03-02) ### Features * Add polling system to dynamic reloading ([googleapis#2466](googleapis#2466)) ([fcaac9b](googleapis@fcaac9b)) * Added basic template for sdks doc migrate ([googleapis#1961](googleapis#1961)) ([87f2eaf](googleapis@87f2eaf)) * **dataproc:** Add dataproc source and list/get clusters/jobs tools ([googleapis#2407](googleapis#2407)) ([cc05e57](googleapis@cc05e57)) * **sources/postgres:** Add configurable pgx query execution mode ([googleapis#2477](googleapis#2477)) ([57b77bc](googleapis@57b77bc)) * **sources/redis:** Add TLS support for Redis connections ([googleapis#2432](googleapis#2432)) ([d6af290](googleapis@d6af290)) * **tools/looker:** Enable Get All Lookml Tests, Run LookML Tests, and Create View From Table tools for Looker ([googleapis#2522](googleapis#2522)) ([e01139a](googleapis@e01139a)) * **tools/looker:** Tools to list/create/delete directories ([googleapis#2488](googleapis#2488)) ([0036d8c](googleapis@0036d8c)) * **ui:** Make tool list panel resizable ([googleapis#2253](googleapis#2253)) ([276cf60](googleapis@276cf60)) ### Bug Fixes * **ci:** Add path for forked PR unit test runs ([googleapis#2540](googleapis#2540)) ([04dd2a7](googleapis@04dd2a7)) * Deflake alloydb omni ([googleapis#2431](googleapis#2431)) ([62b8309](googleapis@62b8309)) * **docs/adk:** Resolve dependency duplication ([googleapis#2418](googleapis#2418)) ([4d44abb](googleapis@4d44abb)) * **docs/langchain:** Fix core at 0.3.0 and align compatible dependencies ([googleapis#2426](googleapis#2426)) ([36edfd3](googleapis@36edfd3)) * Enforce required validation for explicit null parameter values ([googleapis#2519](googleapis#2519)) ([d5e9512](googleapis@d5e9512)) * **oracle:** Enable DML operations and resolve incorrect array type error ([googleapis#2323](googleapis#2323)) ([72146a4](googleapis@72146a4)) * **server/mcp:** Guard nil dereference in sseManager.get ([googleapis#2557](googleapis#2557)) ([e534196](googleapis@e534196)), closes [googleapis#2548](googleapis#2548) * **tests/postgres:** Implement uuid-based isolation and reliable resource cleanup ([googleapis#2377](googleapis#2377)) ([8a96fb1](googleapis@8a96fb1)) * **tests/postgres:** Restore list_schemas test and implement dynamic owner ([googleapis#2521](googleapis#2521)) ([7041e79](googleapis@7041e79)) * **tests:** Resolve LlamaIndex dependency conflict in JS quickstart ([googleapis#2597](googleapis#2597)) ([ac11f5a](googleapis@ac11f5a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com> 81253a0

…y type error (#2323)" This reverts commit 72146a4.

… signature (#2627) ## Description This PR fixes a critical signature mismatch that caused all `oracle-execute-sql` tool invocations to fail with an incompatible source type error (`500` Internal Server Error). In a previous PR (#2323), the `RunSQL` method in the Oracle Source was updated to include a `readOnly` bool parameter to support DML operations for the `oracle-sql` tool: However, the `oracle-execute-sql` tool's required interface (`compatibleSource`) was inadvertently left unchanged, still expecting the old 3-argument signature. Because Go interfaces are satisfied implicitly, the updated Oracle source no longer implemented the `oracle-execute-sql` tool's interface, causing `tools.GetCompatibleSource` to reject it at runtime during invocation. 🛠️ Fixes #2614

…h source signature (googleapis#2627) ## Description This PR fixes a critical signature mismatch that caused all `oracle-execute-sql` tool invocations to fail with an incompatible source type error (`500` Internal Server Error). In a previous PR (googleapis#2323), the `RunSQL` method in the Oracle Source was updated to include a `readOnly` bool parameter to support DML operations for the `oracle-sql` tool: However, the `oracle-execute-sql` tool's required interface (`compatibleSource`) was inadvertently left unchanged, still expecting the old 3-argument signature. Because Go interfaces are satisfied implicitly, the updated Oracle source no longer implemented the `oracle-execute-sql` tool's interface, causing `tools.GetCompatibleSource` to reject it at runtime during invocation. 🛠️ Fixes googleapis#2614 81699a3

… signature (#2627) ## Description This PR fixes a critical signature mismatch that caused all `oracle-execute-sql` tool invocations to fail with an incompatible source type error (`500` Internal Server Error). In a previous PR (#2323), the `RunSQL` method in the Oracle Source was updated to include a `readOnly` bool parameter to support DML operations for the `oracle-sql` tool: However, the `oracle-execute-sql` tool's required interface (`compatibleSource`) was inadvertently left unchanged, still expecting the old 3-argument signature. Because Go interfaces are satisfied implicitly, the updated Oracle source no longer implemented the `oracle-execute-sql` tool's interface, causing `tools.GetCompatibleSource` to reject it at runtime during invocation. 🛠️ Fixes #2614

… signature (googleapis#2627) ## Description This PR fixes a critical signature mismatch that caused all `oracle-execute-sql` tool invocations to fail with an incompatible source type error (`500` Internal Server Error). In a previous PR (googleapis#2323), the `RunSQL` method in the Oracle Source was updated to include a `readOnly` bool parameter to support DML operations for the `oracle-sql` tool: However, the `oracle-execute-sql` tool's required interface (`compatibleSource`) was inadvertently left unchanged, still expecting the old 3-argument signature. Because Go interfaces are satisfied implicitly, the updated Oracle source no longer implemented the `oracle-execute-sql` tool's interface, causing `tools.GetCompatibleSource` to reject it at runtime during invocation. 🛠️ Fixes googleapis#2614

🤖 I have created a release *beep* *boop* --- ## [0.28.0](googleapis/mcp-toolbox@v0.27.0...v0.28.0) (2026-03-02) ### Features * Add polling system to dynamic reloading ([#2466](googleapis/mcp-toolbox#2466)) ([fcaac9b](googleapis/mcp-toolbox@fcaac9b)) * Added basic template for sdks doc migrate ([#1961](googleapis/mcp-toolbox#1961)) ([87f2eaf](googleapis/mcp-toolbox@87f2eaf)) * **dataproc:** Add dataproc source and list/get clusters/jobs tools ([#2407](googleapis/mcp-toolbox#2407)) ([cc05e57](googleapis/mcp-toolbox@cc05e57)) * **sources/postgres:** Add configurable pgx query execution mode ([#2477](googleapis/mcp-toolbox#2477)) ([57b77bc](googleapis/mcp-toolbox@57b77bc)) * **sources/redis:** Add TLS support for Redis connections ([#2432](googleapis/mcp-toolbox#2432)) ([d6af290](googleapis/mcp-toolbox@d6af290)) * **tools/looker:** Enable Get All Lookml Tests, Run LookML Tests, and Create View From Table tools for Looker ([#2522](googleapis/mcp-toolbox#2522)) ([e01139a](googleapis/mcp-toolbox@e01139a)) * **tools/looker:** Tools to list/create/delete directories ([#2488](googleapis/mcp-toolbox#2488)) ([0036d8c](googleapis/mcp-toolbox@0036d8c)) * **ui:** Make tool list panel resizable ([#2253](googleapis/mcp-toolbox#2253)) ([276cf60](googleapis/mcp-toolbox@276cf60)) ### Bug Fixes * **ci:** Add path for forked PR unit test runs ([#2540](googleapis/mcp-toolbox#2540)) ([04dd2a7](googleapis/mcp-toolbox@04dd2a7)) * Deflake alloydb omni ([#2431](googleapis/mcp-toolbox#2431)) ([62b8309](googleapis/mcp-toolbox@62b8309)) * **docs/adk:** Resolve dependency duplication ([#2418](googleapis/mcp-toolbox#2418)) ([4d44abb](googleapis/mcp-toolbox@4d44abb)) * **docs/langchain:** Fix core at 0.3.0 and align compatible dependencies ([#2426](googleapis/mcp-toolbox#2426)) ([36edfd3](googleapis/mcp-toolbox@36edfd3)) * Enforce required validation for explicit null parameter values ([#2519](googleapis/mcp-toolbox#2519)) ([d5e9512](googleapis/mcp-toolbox@d5e9512)) * **oracle:** Enable DML operations and resolve incorrect array type error ([#2323](googleapis/mcp-toolbox#2323)) ([72146a4](googleapis/mcp-toolbox@72146a4)) * **server/mcp:** Guard nil dereference in sseManager.get ([#2557](googleapis/mcp-toolbox#2557)) ([e534196](googleapis/mcp-toolbox@e534196)), closes [#2548](googleapis/mcp-toolbox#2548) * **tests/postgres:** Implement uuid-based isolation and reliable resource cleanup ([#2377](googleapis/mcp-toolbox#2377)) ([8a96fb1](googleapis/mcp-toolbox@8a96fb1)) * **tests/postgres:** Restore list_schemas test and implement dynamic owner ([#2521](googleapis/mcp-toolbox#2521)) ([7041e79](googleapis/mcp-toolbox@7041e79)) * **tests:** Resolve LlamaIndex dependency conflict in JS quickstart ([#2597](googleapis/mcp-toolbox#2597)) ([ac11f5a](googleapis/mcp-toolbox@ac11f5a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com>

… signature (#2627) ## Description This PR fixes a critical signature mismatch that caused all `oracle-execute-sql` tool invocations to fail with an incompatible source type error (`500` Internal Server Error). In a previous PR (googleapis/mcp-toolbox#2323), the `RunSQL` method in the Oracle Source was updated to include a `readOnly` bool parameter to support DML operations for the `oracle-sql` tool: However, the `oracle-execute-sql` tool's required interface (`compatibleSource`) was inadvertently left unchanged, still expecting the old 3-argument signature. Because Go interfaces are satisfied implicitly, the updated Oracle source no longer implemented the `oracle-execute-sql` tool's interface, causing `tools.GetCompatibleSource` to reject it at runtime during invocation. 🛠️ Fixes googleapis/mcp-toolbox#2614

🤖 I have created a release *beep* *boop* --- ## [0.28.0](googleapis/mcp-toolbox@v0.27.0...v0.28.0) (2026-03-02) ### Features * Add polling system to dynamic reloading ([googleapis#2466](googleapis#2466)) ([fcaac9b](googleapis@fcaac9b)) * Added basic template for sdks doc migrate ([googleapis#1961](googleapis#1961)) ([87f2eaf](googleapis@87f2eaf)) * **dataproc:** Add dataproc source and list/get clusters/jobs tools ([googleapis#2407](googleapis#2407)) ([cc05e57](googleapis@cc05e57)) * **sources/postgres:** Add configurable pgx query execution mode ([googleapis#2477](googleapis#2477)) ([57b77bc](googleapis@57b77bc)) * **sources/redis:** Add TLS support for Redis connections ([googleapis#2432](googleapis#2432)) ([d6af290](googleapis@d6af290)) * **tools/looker:** Enable Get All Lookml Tests, Run LookML Tests, and Create View From Table tools for Looker ([googleapis#2522](googleapis#2522)) ([e01139a](googleapis@e01139a)) * **tools/looker:** Tools to list/create/delete directories ([googleapis#2488](googleapis#2488)) ([0036d8c](googleapis@0036d8c)) * **ui:** Make tool list panel resizable ([googleapis#2253](googleapis#2253)) ([276cf60](googleapis@276cf60)) ### Bug Fixes * **ci:** Add path for forked PR unit test runs ([googleapis#2540](googleapis#2540)) ([04dd2a7](googleapis@04dd2a7)) * Deflake alloydb omni ([googleapis#2431](googleapis#2431)) ([62b8309](googleapis@62b8309)) * **docs/adk:** Resolve dependency duplication ([googleapis#2418](googleapis#2418)) ([4d44abb](googleapis@4d44abb)) * **docs/langchain:** Fix core at 0.3.0 and align compatible dependencies ([googleapis#2426](googleapis#2426)) ([36edfd3](googleapis@36edfd3)) * Enforce required validation for explicit null parameter values ([googleapis#2519](googleapis#2519)) ([d5e9512](googleapis@d5e9512)) * **oracle:** Enable DML operations and resolve incorrect array type error ([googleapis#2323](googleapis#2323)) ([72146a4](googleapis@72146a4)) * **server/mcp:** Guard nil dereference in sseManager.get ([googleapis#2557](googleapis#2557)) ([e534196](googleapis@e534196)), closes [googleapis#2548](googleapis#2548) * **tests/postgres:** Implement uuid-based isolation and reliable resource cleanup ([googleapis#2377](googleapis#2377)) ([8a96fb1](googleapis@8a96fb1)) * **tests/postgres:** Restore list_schemas test and implement dynamic owner ([googleapis#2521](googleapis#2521)) ([7041e79](googleapis@7041e79)) * **tests:** Resolve LlamaIndex dependency conflict in JS quickstart ([googleapis#2597](googleapis#2597)) ([ac11f5a](googleapis@ac11f5a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com>

… signature (googleapis#2627) ## Description This PR fixes a critical signature mismatch that caused all `oracle-execute-sql` tool invocations to fail with an incompatible source type error (`500` Internal Server Error). In a previous PR (googleapis#2323), the `RunSQL` method in the Oracle Source was updated to include a `readOnly` bool parameter to support DML operations for the `oracle-sql` tool: However, the `oracle-execute-sql` tool's required interface (`compatibleSource`) was inadvertently left unchanged, still expecting the old 3-argument signature. Because Go interfaces are satisfied implicitly, the updated Oracle source no longer implemented the `oracle-execute-sql` tool's interface, causing `tools.GetCompatibleSource` to reject it at runtime during invocation. 🛠️ Fixes googleapis#2614

separated read-only and dml logic in oracle tool

7c309cc

gemini-code-assist Bot reviewed Jan 16, 2026

View reviewed changes

Comment thread internal/sources/oracle/oracle.go Outdated

Comment thread internal/tools/oracle/oraclesql/oraclesql.go

fix: resolve linter formatting and check errors

42d6a9c

duwenxin99 requested changes Jan 16, 2026

View reviewed changes

Comment thread internal/tools/oracle/oraclesql/oraclesql.go Outdated

Comment thread internal/tools/oracle/oraclesql/oraclesql_test.go Outdated

rename readonly to readOnly and added coverage test cases

8cc8750

duwenxin99 requested changes Jan 21, 2026

View reviewed changes

Comment thread internal/tools/oracle/oraclesql/oraclesql_test.go Outdated

ishatilwani1301 added 7 commits January 23, 2026 06:44

Add integration test case for Oracle DML (readOnly=false)

c1f7400

refactor: remove boolPtr helper

9e4c82c

updated readOnly flag in docs

623aecf

added unit test

f6a4bc2

fix: resolve merge conflicts

2affeaa

refactor tests to resolve errors

37109f6

fix: add missing parameter descriptions to integration test

691412d

ishatilwani1301 added the tests: run Label to trigger Github Action tests. label Feb 2, 2026

github-actions Bot removed the tests: run Label to trigger Github Action tests. label Feb 2, 2026

ishatilwani1301 added 2 commits February 2, 2026 09:49

added ignore links

224afa6

added ignored links and updated integration test

9875486

Ganga4060 mentioned this pull request Feb 3, 2026

Oracle raises error when the query uses "RETURN" keyword #2044

Open

2 tasks

duwenxin99 marked this pull request as ready for review February 3, 2026 16:16

duwenxin99 requested a review from a team February 3, 2026 16:16

blunderbuss-gcf Bot assigned Yuan325 Feb 3, 2026

Merge branch 'main' into fix/oracle-error-in-dml-queries

d9a0065

duwenxin99 added the tests: run Label to trigger Github Action tests. label Feb 4, 2026

github-actions Bot removed the tests: run Label to trigger Github Action tests. label Feb 4, 2026

duwenxin99 assigned duwenxin99 and unassigned Yuan325 Feb 4, 2026

duwenxin99 requested changes Feb 4, 2026

View reviewed changes

Comment thread internal/tools/oracle/oraclesql/oraclesql_test.go

Comment thread tests/oracle/oracle_integration_test.go Outdated

Comment thread tests/oracle/oracle_integration_test.go Outdated

Comment thread internal/sources/oracle/oracle_test.go

ishatilwani1301 and others added 2 commits February 4, 2026 10:38

Merge branch 'main' into fix/oracle-error-in-dml-queries

49b9ff5

rename function name

87eb98d

Merge branch 'main' into fix/oracle-error-in-dml-queries

7d32c7e

duwenxin99 approved these changes Feb 24, 2026

View reviewed changes

Merge branch 'main' into fix/oracle-error-in-dml-queries

7fda3e5

ishatilwani1301 requested a review from a team as a code owner February 25, 2026 04:39

anubhav756 approved these changes Feb 25, 2026

View reviewed changes

ishatilwani1301 merged commit 72146a4 into googleapis:main Feb 25, 2026
18 checks passed

release-please Bot mentioned this pull request Feb 25, 2026

chore(main): release 0.28.0 #2472

Merged

BrewTestBot mentioned this pull request Mar 3, 2026

mcp-toolbox 0.28.0 Homebrew/homebrew-core#270280

Merged

This was referenced Mar 4, 2026

Oracle oracle-execute-sql tool broken in v0.28.0 — RunSQL interface mismatch after DML fix #2614

Closed

fix: Revert "fix(oracle): enable DML operations and resolve incorrect array type error" #2624

Closed

anubhav756 added a commit that referenced this pull request Mar 4, 2026

Revert "fix(oracle): enable DML operations and resolve incorrect arra…

540f40f

…y type error (#2323)" This reverts commit 72146a4.

anubhav756 mentioned this pull request Mar 4, 2026

fix(oracle): update oracle-execute-sql tool interface to match source signature #2627

Merged

gemini-code-assist Bot mentioned this pull request Mar 10, 2026

Fix link check test #2691

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(oracle): enable DML operations and resolve incorrect array type error#2323

fix(oracle): enable DML operations and resolve incorrect array type error#2323
ishatilwani1301 merged 22 commits into
googleapis:mainfrom
ishatilwani1301:fix/oracle-error-in-dml-queries

ishatilwani1301 commented Jan 16, 2026

Uh oh!

gemini-code-assist Bot commented Jan 16, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

duwenxin99 left a comment

Uh oh!

Uh oh!

Uh oh!

duwenxin99 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ishatilwani1301 commented Jan 16, 2026

Uh oh!

gemini-code-assist Bot commented Jan 16, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

duwenxin99 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

duwenxin99 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants