feat(tools/looker): Enable Get All Lookml Tests, Run LookML Tests, and Create View From Table tools for Looker#2522
Conversation
Summary of ChangesHello @Anthrino, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Looker integration within the toolbox by adding a new capability to retrieve LookML tests. This new tool allows users to programmatically fetch and inspect LookML tests defined in a Looker project, facilitating automated validation and deeper insights into data model integrity. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces the get_lookml_tests tool for Looker, enabling users to fetch LookML tests for a specific project. The implementation is generally sound and follows the established patterns for Looker tools in this repository. The identified issues regarding parameter handling in the SDK call, documentation clarity for the LLM, and a mismatch in the integration tests are valid and should be addressed to ensure correctness and maintainability.
|
/gcbrun |
|
You need to add an import for the tool at |
|
/gcbrun |
|
I fixed this up, please pull it down before adding the documents. |
|
Use the changes I made here as a guide for your other two tools. Also, you may want to collapse all three tools into one PR |
|
/gcbrun |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…fig test. fixes for integration tests
dd2a308 to
e84d1ec
Compare
|
/gcbrun |
|
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
Description
Adds a new MCP tool to fetch all available LookML tests for a project that can be executed for validation of changes via the toolbox.
Invokes the Looker API Get All LookML Tests (AllLookmlTests sdk method), which can fetch all defined tests and use the project_id and file_id parameters to narrow the scope as required.
Adds a new MCP tool to run a LookML test for a project.
Adds a new MCP tool to create a new view from a table.
PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
!if this involve a breaking change🛠️ Fixes #2447, #2448, #2450