Skip to content

fix(storage): restore metadata operations timeout in gRPC#14575

Merged
cpriti-os merged 3 commits into
googleapis:mainfrom
cpriti-os:timeout
May 12, 2026
Merged

fix(storage): restore metadata operations timeout in gRPC#14575
cpriti-os merged 3 commits into
googleapis:mainfrom
cpriti-os:timeout

Conversation

@cpriti-os

@cpriti-os cpriti-os commented May 12, 2026

Copy link
Copy Markdown
Contributor

fixes: Issue #14417

@cpriti-os cpriti-os requested review from a team as code owners May 12, 2026 05:14
@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label May 12, 2026
@cpriti-os cpriti-os requested a review from krishnamd-jkp May 12, 2026 05:14
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 12, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the gRPC storage client to remove global timeout overrides and instead applies explicit unbounded timeouts (0s) specifically to streaming RPCs like ReadObject and WriteObject. A new test was added to verify these settings. Feedback was provided regarding the test implementation, specifically suggesting the use of gax.CallOption.Resolve to verify timeout values more robustly instead of relying on brittle string matching of internal library types.

Comment thread storage/grpc_client_test.go
@cpriti-os @gemini-code-assist
apply suggestion from @gemini-code-assist[bot]
fb47599 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
krishnamd-jkp
krishnamd-jkp reviewed May 12, 2026
View reviewed changes
Comment thread storage/grpc_client_test.go Outdated
@krishnamd-jkp

krishnamd-jkp commented May 12, 2026

Copy link
Copy Markdown
Contributor

does adding an integration test (with an induced timeout) help? We can see if the timeout is working as expected.

krishnamd-jkp
krishnamd-jkp reviewed May 12, 2026
View reviewed changes
Comment thread storage/grpc_client.go
@cpriti-os

cpriti-os commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

does adding an integration test (with an induced timeout) help? We can see if the timeout is working as expected.

I dont think so, the unit test takes care of the change we are making, testing timeouts in integration tests could add unnecessary complexity and flakiness.

@cpriti-os cpriti-os merged commit 275ff56 into googleapis:main May 12, 2026
11 checks passed
@krishnamd-jkp krishnamd-jkp mentioned this pull request May 15, 2026
Closed
This was referenced May 18, 2026
Closed
Merged
cpriti-os added a commit that referenced this pull request May 18, 2026
@cpriti-os
chore: librarian release pull request: 20260518T161338Z (#14610)
50a5755 
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.13.2-0.20260514223035-a22d6b5a1329
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:b04b076f5eedbb5546bd6fc1404969dd3698c8b19c0f34ae815a84ae735a606a
<details><summary>storage: v1.62.2</summary>

##
[v1.62.2](storage/v1.62.1...storage/v1.62.2)
(2026-05-18)

### Features

* enable open telemetry attrs (#14426)
([74eab64](74eab64d))

### Bug Fixes

* restore metadata operations timeout in gRPC (#14575)
([275ff56](275ff562))

* Set default chunkRetryDeadline to 32s in NewWriterFromAppendableObject
(#14458)
([ec7c7d6](ec7c7d66))

* refactor userProject metadata propagation in ListObjects (#14533)
([fbb543e](fbb543e3))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krishnamd-jkp krishnamd-jkp krishnamd-jkp approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cpriti-os @krishnamd-jkp