fix(storage): Set default chunkRetryDeadline to 32s in NewWriterFromAppendableObject#14458
Merged
Conversation
Set ChunkRetryDeadline to 32 seconds explicitly when not set in the AppendableWriterOpts, so that the initial bidi stream open call correctly inherits the deadline. Co-authored-by: cpriti-os <202586561+cpriti-os@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the NewWriterFromAppendableObject function in storage/storage.go to initialize the ChunkRetryDeadline with a default value of 32 seconds if it is not already set. I have no feedback to provide as there were no review comments.
hongalex
approved these changes
Apr 20, 2026
krishnamd-jkp
approved these changes
Apr 21, 2026
This was referenced May 18, 2026
cpriti-os
added a commit
that referenced
this pull request
May 18, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.13.2-0.20260514223035-a22d6b5a1329 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:b04b076f5eedbb5546bd6fc1404969dd3698c8b19c0f34ae815a84ae735a606a <details><summary>storage: v1.62.2</summary> ## [v1.62.2](storage/v1.62.1...storage/v1.62.2) (2026-05-18) ### Features * enable open telemetry attrs (#14426) ([74eab64](74eab64d)) ### Bug Fixes * restore metadata operations timeout in gRPC (#14575) ([275ff56](275ff562)) * Set default chunkRetryDeadline to 32s in NewWriterFromAppendableObject (#14458) ([ec7c7d6](ec7c7d66)) * refactor userProject metadata propagation in ListObjects (#14533) ([fbb543e](fbb543e3)) </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: The chunkRetryDeadline defaults to 0s when using NewWriterFromAppendableObject if not explicitly set, instead of the expected 32s.
b/416635349