feat(core): transaction.set_data sets data on TraceContext#739
Merged
Conversation
Swatinem
approved these changes
Feb 6, 2025
…ata attributes instead of extra
8117ef6 to
214a25f
Compare
Member
Author
|
Changed existing APIs that access/mutate Transaction data (used in the |
Swatinem
approved these changes
Feb 6, 2025
Contributor
Swatinem
left a comment
There was a problem hiding this comment.
lgtm! its good to have someone who actually knows how all of this is supposed to work within SDKs :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rust SDK currently sets data on
transaction.extrawhen callingtransaction.set_dataon aTransaction.This change makes it so that data is instead set on the
TraceContexti.e.transaction.context.trace.dataas other SDKs do (see getsentry/team-sdks#95).Required for #733