Merged
Conversation
5b982d8 to
be77ded
Compare
c406760 to
f9a0618
Compare
sl0thentr0py
commented
Jul 6, 2023
tests/test_monitor.py
Outdated
| monitor.interval = 0.1 | ||
|
|
||
| assert monitor.is_healthy() is True | ||
| sleep(0.1) # wait for monitor to run |
Member
Author
There was a problem hiding this comment.
if this thread stuff turns out to be flaky with timing, i'll change the logic later
sentrivana
approved these changes
Jul 7, 2023
Contributor
sentrivana
left a comment
There was a problem hiding this comment.
lgtm, left some optional suggestions
08efcfe to
1f27ad4
Compare
sl0thentr0py
added a commit
to getsentry/sentry
that referenced
this pull request
Jul 10, 2023
…100% sampling (#52104) We want to eventually end up in a state where we sample at 100% client (sdk) side. Not being sure about the impact of just turning this on throughout the system, we will do it in steps with the new `SENTRY_MULTIPLIER_APM_SAMPLING` config that we will bump in steps, first on isolated instances and then everywhere till we either * get to 100% sampling * find and document problems that we can handle via [backpressure management](getsentry/sentry-python#2189) in SDKs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable_backpressure_handlingrelated to #2095 and getsentry/team-sdks#10