feat(sdk): Add sampling multiplier config as an intermediate step to 100% sampling#52104
Merged
sl0thentr0py merged 1 commit intomasterfrom Jul 10, 2023
Merged
feat(sdk): Add sampling multiplier config as an intermediate step to 100% sampling#52104sl0thentr0py merged 1 commit intomasterfrom
sl0thentr0py merged 1 commit intomasterfrom
Conversation
untitaker
approved these changes
Jul 3, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52104 +/- ##
==========================================
+ Coverage 77.48% 79.32% +1.83%
==========================================
Files 4912 4910 -2
Lines 206147 205971 -176
Branches 35225 35194 -31
==========================================
+ Hits 159737 163390 +3653
+ Misses 41358 37584 -3774
+ Partials 5052 4997 -55
|
6717be3 to
6741d86
Compare
100% sampling We want to eventually end up in a state where we sample at 100% client (sdk) side. Not being sure about the impact of just turning this on throughout, we will do it in steps wit the new `SENTRY_MULTIPLIER_APM_SAMPLING` config that we will bump in steps, first on isolated instances and then throughout till we * get to 100% sampling * find and document problems that we can handle via backpressure management in SDKs
6741d86 to
8dc373d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to eventually end up in a state where we sample at 100% client (sdk) side.
Not being sure about the impact of just turning this on throughout the system,
we will do it in steps with the new
SENTRY_MULTIPLIER_APM_SAMPLINGconfig that we will bump in steps,first on isolated instances and then everywhere till we either