Create modules for integrations by ribice · Pull Request #919 · getsentry/sentry-go

ribice · 2024-12-08T18:34:49Z

Closes #156

codecov · 2024-12-08T18:40:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.56%. Comparing base (77bd21b) to head (388b4d9).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #919      +/-   ##
==========================================
- Coverage   83.85%   83.56%   -0.30%     
==========================================
  Files          49       49              
  Lines        5128     5128              
==========================================
- Hits         4300     4285      -15     
- Misses        674      687      +13     
- Partials      154      156       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ribice · 2024-12-08T21:50:16Z

I haven't touched any dependencies (version), but it's complaining about Fiber. I'll just update it I guess. cc @cleptric

ribice · 2024-12-08T22:38:55Z

Tested locally, works fine. This is technically a breaking change since if someone runs go get -u github.com/getsentry/sentry-go, they'll need to run go get github.com/getsentry/sentry-go/integration (or go get ./...) to make their application work.

cleptric · 2024-12-11T13:53:05Z

CHANGELOG.md


 - Remove all code related to Sentry's previous Metrics product. Read more about the end of the Metrics beta ([here](https://sentry.zendesk.com/hc/en-us/articles/26369339769883-Metrics-Beta-Ended-on-October-7th)) ([#914](https://github.com/getsentry/sentry-go/pull/914))

+- Every integration is now a separate module, reducing the binary size and number of dependencies. Once you update `sentry-go` to latest version, you'll need to `go get` the integration you want to use. For example, if you want to use the `echo` integration, you'll need to run `go get github.com/getsentry/sentry-go/echo` ([#919](github.com/getsentry/sentry-go/pull/919)).


reducing the binary size

This should not be the case due to Module Graph Pruning.

Hmm, I tested this locally just to make sure. Imported echo only, and did go build .

echo-new 4931.21 KB
echo-old 4948.81 KB

go build -ldflags " -s -w" .

echo-new 3454.99 KB echo-old 3472.00 KB

…37019) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/getsentry/sentry-go](https://redirect.github.com/getsentry/sentry-go) | `v0.30.0` -> `v0.31.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgetsentry%2fsentry-go/v0.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgetsentry%2fsentry-go/v0.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgetsentry%2fsentry-go/v0.30.0/v0.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgetsentry%2fsentry-go/v0.30.0/v0.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>getsentry/sentry-go (github.com/getsentry/sentry-go)</summary> ### [`v0.31.1`](https://redirect.github.com/getsentry/sentry-go/releases/tag/v0.31.1): 0.31.1 [Compare Source](https://redirect.github.com/getsentry/sentry-go/compare/v0.31.0...v0.31.1) The Sentry SDK team is happy to announce the immediate availability of Sentry Go SDK v0.31.1. ##### Bug Fixes - Correct wrong module name for `sentry-go/logrus` ([#950](https://redirect.github.com/getsentry/sentry-go/pull/950)) ### [`v0.31.0`](https://redirect.github.com/getsentry/sentry-go/releases/tag/v0.31.0): 0.31.0 [Compare Source](https://redirect.github.com/getsentry/sentry-go/compare/v0.30.0...v0.31.0) ##### Breaking Changes - Remove support for metrics. Read more about the end of the Metrics beta [here](https://sentry.zendesk.com/hc/en-us/articles/26369339769883-Metrics-Beta-Ended-on-October-7th). ([#914](https://redirect.github.com/getsentry/sentry-go/pull/914)) - Remove support for profiling. ([#915](https://redirect.github.com/getsentry/sentry-go/pull/915)) - Remove `Segment` field from the `User` struct. This field is no longer used in the Sentry product. ([#928](https://redirect.github.com/getsentry/sentry-go/pull/928)) - Every integration is now a separate module, reducing the binary size and number of dependencies. Once you update `sentry-go` to latest version, you'll need to `go get` the integration you want to use. For example, if you want to use the `echo` integration, you'll need to run `go get github.com/getsentry/sentry-go/echo` ([#919](redirect.github.com/getsentry/sentry-go/pull/919)). ##### Features Add the ability to override `hub` in `context` for integrations that use custom context. ([#931](https://redirect.github.com/getsentry/sentry-go/pull/931)) - Add `HubProvider` Hook for `sentrylogrus`, enabling dynamic Sentry hub allocation for each log entry or goroutine. ([#936](https://redirect.github.com/getsentry/sentry-go/pull/936)) This change enhances compatibility with Sentry's recommendation of using separate hubs per goroutine. To ensure a separate Sentry hub for each goroutine, configure the `HubProvider` like this: ```go hook, err := sentrylogrus.New(nil, sentry.ClientOptions{}) if err != nil { log.Fatalf("Failed to initialize Sentry hook: %v", err) } // Set a custom HubProvider to generate a new hub for each goroutine or log entry hook.SetHubProvider(func() *sentry.Hub { client, _ := sentry.NewClient(sentry.ClientOptions{}) return sentry.NewHub(client, sentry.NewScope()) }) logrus.AddHook(hook) ``` ##### Bug Fixes - Add support for closing worker goroutines started by the `HTTPTranport` to prevent goroutine leaks. ([#894](https://redirect.github.com/getsentry/sentry-go/pull/894)) ```go client, _ := sentry.NewClient() defer client.Close() ``` Worker can be also closed by calling `Close()` method on the `HTTPTransport` instance. `Close` should be called after `Flush` and before terminating the program otherwise some events may be lost. ```go transport := sentry.NewHTTPTransport() defer transport.Close() ``` ##### Misc - Bump [gin-gonic/gin](https://redirect.github.com/gin-gonic/gin) to v1.9.1. ([#946](https://redirect.github.com/getsentry/sentry-go/pull/946)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>

…pen-telemetry#37019) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/getsentry/sentry-go](https://redirect.github.com/getsentry/sentry-go) | `v0.30.0` -> `v0.31.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgetsentry%2fsentry-go/v0.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgetsentry%2fsentry-go/v0.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgetsentry%2fsentry-go/v0.30.0/v0.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgetsentry%2fsentry-go/v0.30.0/v0.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>getsentry/sentry-go (github.com/getsentry/sentry-go)</summary> ### [`v0.31.1`](https://redirect.github.com/getsentry/sentry-go/releases/tag/v0.31.1): 0.31.1 [Compare Source](https://redirect.github.com/getsentry/sentry-go/compare/v0.31.0...v0.31.1) The Sentry SDK team is happy to announce the immediate availability of Sentry Go SDK v0.31.1. ##### Bug Fixes - Correct wrong module name for `sentry-go/logrus` ([#&open-telemetry#8203;950](https://redirect.github.com/getsentry/sentry-go/pull/950)) ### [`v0.31.0`](https://redirect.github.com/getsentry/sentry-go/releases/tag/v0.31.0): 0.31.0 [Compare Source](https://redirect.github.com/getsentry/sentry-go/compare/v0.30.0...v0.31.0) ##### Breaking Changes - Remove support for metrics. Read more about the end of the Metrics beta [here](https://sentry.zendesk.com/hc/en-us/articles/26369339769883-Metrics-Beta-Ended-on-October-7th). ([#&open-telemetry#8203;914](https://redirect.github.com/getsentry/sentry-go/pull/914)) - Remove support for profiling. ([#&open-telemetry#8203;915](https://redirect.github.com/getsentry/sentry-go/pull/915)) - Remove `Segment` field from the `User` struct. This field is no longer used in the Sentry product. ([#&open-telemetry#8203;928](https://redirect.github.com/getsentry/sentry-go/pull/928)) - Every integration is now a separate module, reducing the binary size and number of dependencies. Once you update `sentry-go` to latest version, you'll need to `go get` the integration you want to use. For example, if you want to use the `echo` integration, you'll need to run `go get github.com/getsentry/sentry-go/echo` ([#&open-telemetry#8203;919](redirect.github.com/getsentry/sentry-go/pull/919)). ##### Features Add the ability to override `hub` in `context` for integrations that use custom context. ([#&open-telemetry#8203;931](https://redirect.github.com/getsentry/sentry-go/pull/931)) - Add `HubProvider` Hook for `sentrylogrus`, enabling dynamic Sentry hub allocation for each log entry or goroutine. ([#&open-telemetry#8203;936](https://redirect.github.com/getsentry/sentry-go/pull/936)) This change enhances compatibility with Sentry's recommendation of using separate hubs per goroutine. To ensure a separate Sentry hub for each goroutine, configure the `HubProvider` like this: ```go hook, err := sentrylogrus.New(nil, sentry.ClientOptions{}) if err != nil { log.Fatalf("Failed to initialize Sentry hook: %v", err) } // Set a custom HubProvider to generate a new hub for each goroutine or log entry hook.SetHubProvider(func() *sentry.Hub { client, _ := sentry.NewClient(sentry.ClientOptions{}) return sentry.NewHub(client, sentry.NewScope()) }) logrus.AddHook(hook) ``` ##### Bug Fixes - Add support for closing worker goroutines started by the `HTTPTranport` to prevent goroutine leaks. ([#&open-telemetry#8203;894](https://redirect.github.com/getsentry/sentry-go/pull/894)) ```go client, _ := sentry.NewClient() defer client.Close() ``` Worker can be also closed by calling `Close()` method on the `HTTPTransport` instance. `Close` should be called after `Flush` and before terminating the program otherwise some events may be lost. ```go transport := sentry.NewHTTPTransport() defer transport.Close() ``` ##### Misc - Bump [gin-gonic/gin](https://redirect.github.com/gin-gonic/gin) to v1.9.1. ([#&open-telemetry#8203;946](https://redirect.github.com/getsentry/sentry-go/pull/946)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>

ribice added 2 commits December 8, 2024 19:31

create modules for all integrations

3118937

add documentation for slog

4e0d906

go mod tidy

f745227

update dependencies for fiber

049fa4d

ribice marked this pull request as ready for review December 8, 2024 22:37

update changelog

b1a9ec3

cleptric assigned ribice Dec 10, 2024

cleptric added Type: Breaking labels Dec 10, 2024

cleptric self-requested a review December 10, 2024 14:54

Merge branch 'master' into integrations-modules

8f452c6

cleptric reviewed Dec 11, 2024

View reviewed changes

ribice and others added 4 commits December 12, 2024 00:08

resolve conflicts

1becb51

update crypto dependency

f3ceb2f

tidy go mod

db3679e

Merge branch 'master' into integrations-modules

388b4d9

cleptric approved these changes Dec 16, 2024

View reviewed changes

ribice merged commit 3a08424 into master Dec 16, 2024

ribice deleted the integrations-modules branch December 16, 2024 14:48

cleptric added a commit that referenced this pull request Dec 30, 2024

Revert “Create modules for integrations (#919)”

63c47ce

cleptric added a commit that referenced this pull request Dec 30, 2024

Revert “Create modules for integrations (#919)” (#942)

17adca9

leighmcculloch mentioned this pull request Jan 2, 2025

Split sentry-go into multiple submodules #156

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create modules for integrations#919

Create modules for integrations#919
ribice merged 10 commits intomasterfrom
integrations-modules

ribice commented Dec 8, 2024 •

edited by cleptric

Loading

Uh oh!

codecov bot commented Dec 8, 2024 •

edited

Loading

Uh oh!

ribice commented Dec 8, 2024

Uh oh!

ribice commented Dec 8, 2024

Uh oh!

cleptric Dec 11, 2024

Uh oh!

ribice Dec 11, 2024

Uh oh!

ribice Dec 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		- Remove all code related to Sentry's previous Metrics product. Read more about the end of the Metrics beta ([here](https://sentry.zendesk.com/hc/en-us/articles/26369339769883-Metrics-Beta-Ended-on-October-7th)) ([#914](https://github.com/getsentry/sentry-go/pull/914))

		- Every integration is now a separate module, reducing the binary size and number of dependencies. Once you update `sentry-go` to latest version, you'll need to `go get` the integration you want to use. For example, if you want to use the `echo` integration, you'll need to run `go get github.com/getsentry/sentry-go/echo` ([#919](github.com/getsentry/sentry-go/pull/919)).

Conversation

ribice commented Dec 8, 2024 • edited by cleptric Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Dec 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ribice commented Dec 8, 2024

Uh oh!

ribice commented Dec 8, 2024

Uh oh!

cleptric Dec 11, 2024

Choose a reason for hiding this comment

Uh oh!

ribice Dec 11, 2024

Choose a reason for hiding this comment

Uh oh!

ribice Dec 11, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ribice commented Dec 8, 2024 •

edited by cleptric

Loading

codecov bot commented Dec 8, 2024 •

edited

Loading