Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #928 +/- ##
==========================================
+ Coverage 83.83% 83.85% +0.01%
==========================================
Files 49 49
Lines 5135 5128 -7
==========================================
- Hits 4305 4300 -5
+ Misses 676 674 -2
Partials 154 154 ☔ View full report in Codecov by Sentry. |
cleptric
reviewed
Dec 11, 2024
interfaces.go
Outdated
Comment on lines
+115
to
+119
| // Segment is a string representing the user segment that the user belongs to. | ||
| // | ||
| // Deprecated: Segment is deprecated and will be removed in the next major | ||
| // of the Sentry Go SDK. | ||
| Segment string `json:"segment,omitempty"` |
Member
There was a problem hiding this comment.
Feel free to remove it right now, the next release contains some breaking changes as well.
cleptric
approved these changes
Dec 11, 2024
Contributor
Author
Collaborator
|
@AbhiPrasad Please update Changelog as well with this change. |
Contributor
Author
8b89a4e to
a42721e
Compare
f580abc to
7bc7226
Compare
Member
|
Thanks @AbhiPrasad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref getsentry/team-sdks#44
Remove user segment and all user segment related logic.
https://go.dev/ref/mod#go-mod-file-module-deprecation