chore!: remove plugins-benchmark-pr workflow#196
Merged
Merged
Conversation
Signed-off-by: Frazer Smith <frazer.dev@icloud.com>
Eomm
reviewed
Nov 12, 2025
Eomm
left a comment
Member
There was a problem hiding this comment.
This is a breaking change so will require a major version bump.
What? 😄
Can we create an issue in the workflow repo to recreate this action there?
Member
Author
What? We're removing functionality by getting rid of the workflow, so technically breaking? |
gurgunday
approved these changes
Nov 12, 2025
gurgunday
left a comment
Member
There was a problem hiding this comment.
it's kinda sad that we won't be able to run benchmarks on the CI :(
Uzlopak
approved these changes
Nov 13, 2025
Contributor
|
reusable workflows are using git tags for "versioning". So after merging this PR, we need to make a tag 6.0.0 |
Eomm
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See fastify/fastify#6322.
This resolves https://github.com/fastify/workflows/security/code-scanning/17 and https://github.com/fastify/workflows/security/code-scanning/18. None of our repos are using it anyway.
This is a breaking change so will require a major version bump.
Checklist
and the Code of conduct