Conversation
Signed-off-by: Manuel Spigolon <behemoth89@gmail.com>
Signed-off-by: Manuel Spigolon <behemoth89@gmail.com>
|
Why? |
|
This is the full documentation: Since we are checking out external code, a malicious user may run external code in our org GHA context. While this is almost impossible because:
Nevertheless, this is considered a potential security threat and is flagged as critical by the OpenSSF working group. Our scope is to reduce any potential issue to zero, even tho it may require some extra work to move the GHA into a repo that could be exploited without harm |
|
Happy for them to be removed for now to reduce any immediate potential nastiness. We can revisit them and do what is suggested in https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/ and split the workflows. Note that https://github.com/fastify/workflows/blob/main/.github/workflows/plugins-benchmark-pr.yml also has the same codeql alerts. |
See fastify/fastify#6322 Signed-off-by: Frazer Smith <frazer.dev@icloud.com>
See fastify/fastify#6322 Signed-off-by: Frazer Smith <frazer.dev@icloud.com>
Even tho these workflow are triggered manually, we must remove them 😢
This is not a farewell, to add them back, we need another workflow:
https://scorecard.dev/viewer/?uri=github.com%2Ffastify%2Ffastify
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct