[lexical-table] Bug Fix: prevent crash when moving selection with arrow key outside of nested table#8502
Merged
etrepum merged 1 commit intoMay 13, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
approved these changes
May 12, 2026
Collaborator
|
I'm going to go ahead and merge this even without tests since we don't really have actual support for nested tables yet and it's clearly an improvement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #8484
Problem: With a table selection on a nested table, the arrow key handler would fire for both the parent and the nested table, and this breaks one of the invariants (
LexicalTableObserver.$updateTableTableSelection).The problem is similar in nature to the mouse selection bugs that were fixed by refactoring selection to be registered once, and handle all of the tables. Ideally we would do the same for the arrow key handler, but for now, this prevents the editor crash.
Test plan
Before
Insert relevant screenshots/recordings/automated-tests
After
Insert relevant screenshots/recordings/automated-tests