Skip to content

fix: remove extra json convert check#5501

Merged
Skarlso merged 1 commit intoexternal-secrets:mainfrom
Skarlso:fix-extra-json-check
Oct 24, 2025
Merged

fix: remove extra json convert check#5501
Skarlso merged 1 commit intoexternal-secrets:mainfrom
Skarlso:fix-extra-json-check

Conversation

@Skarlso
Copy link
Copy Markdown
Contributor

@Skarlso Skarlso commented Oct 24, 2025

Problem Statement

The refactor put in an extra if check that was causing problems.

Related Issue

Fixes #5492

Proposed Changes

How do you like to solve the issue and why?

Format

Please ensure that your PR follows the following format for the title:

feat(scope): add new feature
fix(scope): fix bug
docs(scope): update documentation
chore(scope): update build tool or dependencies
ref(scope): refactor code
clean(scope): provider cleanup
test(scope): add tests
perf(scope): improve performance
desig(scope): improve design

Where scope is optionally one of:

  • charts
  • release
  • testing
  • security
  • templating

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>
@github-actions github-actions bot added kind/bug Categorizes issue or PR as related to a bug. size/xs labels Oct 24, 2025
@sonarqubecloud
Copy link
Copy Markdown

@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Oct 24, 2025

/ok-to-test sha=02d4fbb02ce2db3a193775d27bb5796b2799f96a

@eso-service-account-app
Copy link
Copy Markdown
Contributor

@Skarlso Skarlso merged commit 9ee12d5 into external-secrets:main Oct 24, 2025
28 checks passed
SamuelMolling pushed a commit to SamuelMolling/external-secrets that referenced this pull request Oct 24, 2025
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>
Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. size/xs

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

PushSecret fails to sync secrets to Vault in v0.20.3

2 participants