Skip to content

chore(docs): update refresh interval format#5447

Merged
Skarlso merged 2 commits intoexternal-secrets:mainfrom
Skarlso:fix-refresh-interval
Oct 10, 2025
Merged

chore(docs): update refresh interval format#5447
Skarlso merged 2 commits intoexternal-secrets:mainfrom
Skarlso:fix-refresh-interval

Conversation

@Skarlso
Copy link
Copy Markdown
Contributor

@Skarlso Skarlso commented Oct 10, 2025

Problem Statement

What is the problem you're trying to solve?

Related Issue

Fixes #5390

Kubernetes 0.34 changed refresh interval's ToString causing some problems during display that the samples are not showing. Updated the samples to match the new look.

Proposed Changes

How do you like to solve the issue and why?

Format

Please ensure that your PR follows the following format for the title:

feat(scope): add new feature
fix(scope): fix bug
docs(scope): update documentation
chore(scope): update build tool or dependencies
ref(scope): refactor code
clean(scope): provider cleanup
test(scope): add tests
perf(scope): improve performance
desig(scope): improve design

Where scope is optionally one of:

  • charts
  • release
  • testing
  • security
  • templating

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

@github-actions github-actions bot added kind/documentation Categorizes issue or PR as related to documentation. area/docs kind/chore Categorizes Pull Requests for chore activities (like bumping versions) labels Oct 10, 2025
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>
@Skarlso Skarlso force-pushed the fix-refresh-interval branch from 6349903 to 7185f6f Compare October 10, 2025 10:58
@sonarqubecloud
Copy link
Copy Markdown

@Skarlso Skarlso merged commit 44f1add into external-secrets:main Oct 10, 2025
29 checks passed
SamuelMolling pushed a commit to SamuelMolling/external-secrets that referenced this pull request Oct 24, 2025
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Co-authored-by: Idan Adar <iadar@il.ibm.com>
Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs kind/chore Categorizes Pull Requests for chore activities (like bumping versions) kind/documentation Categorizes issue or PR as related to documentation. size/s

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

refreshinterval changed in version v0.20.1

3 participants