refreshinterval changed in version v0.20.1 #5390
Description
Describe the bug
I apologize, my request is not a bug report — it’s more of a question.
We are testing an upgrade of ESO from version v0.18.2 to the latest at the moment, v0.20.1.
In version v0.18.2:
kubectl get externalsecrets.external-secrets.io
NAME STORETYPE STORE REFRESH INTERVAL
secret-name ClusterSecretStore cluster-secretstore 15m
secret-name-dev-1 ClusterSecretStore cluster-secretstore 60m
We can see the refreshInterval displayed in minutes without seconds.
But in version v0.20.1:
kubectl get externalsecrets.external-secrets.io
NAME STORETYPE STORE REFRESH INTERVAL
secret-name ClusterSecretStore cluster-secretstore 15m0s
secret-name-dev-1 ClusterSecretStore cluster-secretstore 1h0m0s
Now the refreshInterval includes seconds. So if we previously had 60m, it is now displayed as 1h0m0s, and ArgoCD marks these ESO objects as OutOfSync.
In our Helm templates we were specifying it like this:
apiVersion: external-secrets.io/v1
kind: ExternalSecret
metadata:
name: {{ $serviceName }}.{{ $name }}.{{ $key_name }}
labels:
{{- include "core.labels" $ | nindent 4 }}
spec:
refreshInterval: 15m
secretStoreRef:
name: cluster-secretstore
target:
name: {{ $serviceName }}.{{ $name }}.{{ $key_name }}
creationPolicy: Owner
template:
engineVersion: v2
data:
key: {{`"{{ .key }}"`}}
metadata:
How should refreshInterval be specified now?
To Reproduce
Steps to reproduce the behavior:
- upgrade from v0.18.2 to v0.20.1