Skip to content

fix(ci): listing required roles should NOT mention/tag the roles, just name them.#5363

Merged
Skarlso merged 1 commit intoexternal-secrets:mainfrom
webstradev:lgtm-fixes
Sep 24, 2025
Merged

fix(ci): listing required roles should NOT mention/tag the roles, just name them.#5363
Skarlso merged 1 commit intoexternal-secrets:mainfrom
webstradev:lgtm-fixes

Conversation

@webstradev
Copy link
Copy Markdown
Contributor

@webstradev webstradev commented Sep 24, 2025

Problem Statement

We don't actually want to mention/notify the required roles in this message, the goal is only to inform the commenter what roles are necessary. We do this the same way in other areas of this workflow.

Related Issue

Fixes #...

Proposed Changes

Trim off the organisazation and only use the name of the role, so maintainer, not @external-secrets/maintainer

Format

Please ensure that your PR follows the following format for the title:

feat(scope): add new feature
fix(scope): fix bug
docs(scope): update documentation
chore(scope): update build tool or dependencies
ref(scope): refactor code
clean(scope): provider cleanup
test(scope): add tests
perf(scope): improve performance
desig(scope): improve design

Where scope is optionally one of:

  • charts
  • release
  • testing
  • security
  • templating

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

@github-actions github-actions bot added area/ci Pull requests that update Github_actions code kind/bug Categorizes issue or PR as related to a bug. component/github-actions size/xs labels Sep 24, 2025
…st the title.

Signed-off-by: Erik Westra <e.s.westra.95@gmail.com>
@sonarqubecloud
Copy link
Copy Markdown

@Skarlso Skarlso merged commit dc91868 into external-secrets:main Sep 24, 2025
7 checks passed
SamuelMolling pushed a commit to SamuelMolling/external-secrets that referenced this pull request Oct 24, 2025
…st the title. (external-secrets#5363)

Signed-off-by: Erik Westra <e.s.westra.95@gmail.com>
Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci Pull requests that update Github_actions code component/github-actions kind/bug Categorizes issue or PR as related to a bug. size/xs

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants