fix(ci): listing required roles should NOT mention/tag the roles, just name them.#5363
Merged
Skarlso merged 1 commit intoexternal-secrets:mainfrom Sep 24, 2025
Merged
Conversation
…st the title. Signed-off-by: Erik Westra <e.s.westra.95@gmail.com>
479d41a to
f8c2ebc
Compare
|
Skarlso
approved these changes
Sep 24, 2025
SamuelMolling
pushed a commit
to SamuelMolling/external-secrets
that referenced
this pull request
Oct 24, 2025
…st the title. (external-secrets#5363) Signed-off-by: Erik Westra <e.s.westra.95@gmail.com> Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem Statement
We don't actually want to mention/notify the required roles in this message, the goal is only to inform the commenter what roles are necessary. We do this the same way in other areas of this workflow.
Related Issue
Fixes #...
Proposed Changes
Trim off the organisazation and only use the name of the role, so maintainer, not @external-secrets/maintainer
Format
Please ensure that your PR follows the following format for the title:
Where
scopeis optionally one of:Checklist
git commit --signoffmake testmake reviewable