Merged
Conversation
Contributor
Author
|
Oh God, why again Edit: |
Contributor
|
In general, this looks okay to me. Could you please show some working examples of this? Like paste in the created secret, show that it reconciled, etc? |
Contributor
Author
|
Here you are: apiVersion: generators.external-secrets.io/v1alpha1
kind: SSHKey
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"generators.external-secrets.io/v1alpha1","kind":"SSHKey","metadata":{"annotations":{},"name":"example-ssh-key","namespace":"default"},"spec":{"comment":"user@example.com","keyType":"ed25519"}}
creationTimestamp: "2025-07-30T00:26:51Z"
generation: 2
name: example-ssh-key
namespace: default
resourceVersion: "355930"
uid: fde7d258-14d7-4c30-8e9d-f9fad95cc036
spec:
comment: user@example.com
keySize: 2048
keyType: ed25519apiVersion: v1
data:
privateKey: LS0tLS1CRUdJTiBPUEVOU1NIIFBSSVZBVEUgS0VZLS0tLS0KYjNCbGJuTnphQzFyWlhrdGRqRUFBQUFBQkc1dmJtVUFBQUFFYm05dVpRQUFBQUFBQUFBQkFBQUFNd0FBQUF0egpjMmd0WldReU5UVXhPUUFBQUNCeW1JcWN4WVpCWncrbnN1b1JFdHl2S2NYbGdvbHBwSjRJZWpQb29MUHhSQUFBCkFKamd3a0J4NE1KQWNRQUFBQXR6YzJndFpXUXlOVFV4T1FBQUFDQnltSXFjeFlaQlp3K25zdW9SRXR5dktjWGwKZ29scHBKNEllalBvb0xQeFJBQUFBRURWUkZsdWpPVWc3cFJWZkZqRjZPekdvVkhWKzMwejBBdnMzT3RQTzlOcwo4SEtZaXB6RmhrRm5ENmV5NmhFUzNLOHB4ZVdDaVdta25naDZNK2lncy9GRUFBQUFFSFZ6WlhKQVpYaGhiWEJzClpTNWpiMjBCQWdNRUJRPT0KLS0tLS1FTkQgT1BFTlNTSCBQUklWQVRFIEtFWS0tLS0tCg==
publicKey: c3NoLWVkMjU1MTkgQUFBQUMzTnphQzFsWkRJMU5URTVBQUFBSUhLWWlwekZoa0ZuRDZleTZoRVMzSzhweGVXQ2lXbWtuZ2g2TStpZ3MvRkUgdXNlckBleGFtcGxlLmNvbQo=
kind: Secret
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"external-secrets.io/v1","kind":"ExternalSecret","metadata":{"annotations":{},"name":"example-ssh-key","namespace":"default"},"spec":{"dataFrom":[{"sourceRef":{"generatorRef":{"apiVersion":"generators.external-secrets.io/v1alpha1","kind":"SSHKey","name":"example-ssh-key"}}}],"refreshInterval":"30m","target":{"name":"ssh-key-secret"}}}
reconcile.external-secrets.io/data-hash: 1557de1a741f02070760c1a64529d0b1c4c1ec9289d7cfc397bf6357
creationTimestamp: "2025-07-30T00:48:09Z"
labels:
reconcile.external-secrets.io/created-by: 8841e71abe51cc9f72aaa4934514304cd241f42fc536ea8b26b01f31
reconcile.external-secrets.io/managed: "true"
name: ssh-key-secret
namespace: default
ownerReferences:
- apiVersion: external-secrets.io/v1
blockOwnerDeletion: true
controller: true
kind: ExternalSecret
name: example-ssh-key
uid: 6c81c9e6-9531-4780-af97-a8f877e12aab
resourceVersion: "358797"
uid: b24e5abd-c9fc-4c2b-9bbb-aa624bd97fbf
type: Opaquewhich is after base64 decode: and log: |
Contributor
Author
|
I'm going to make keySize nullable as it is misleading to see default 2048 for |
Contributor
Author
|
3 examples: apiVersion: generators.external-secrets.io/v1alpha1
kind: SSHKey
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: >
{"apiVersion":"generators.external-secrets.io/v1alpha1","kind":"SSHKey","metadata":{"annotations":{},"name":"example-ssh-key","namespace":"default"},"spec":{"comment":"user@example.com","keyType":"ed25519"}}
creationTimestamp: "2025-07-30T09:06:44Z"
generation: 1
name: example-ssh-key
namespace: default
resourceVersion: "365345"
selfLink: >-
/apis/generators.external-secrets.io/v1alpha1/namespaces/default/sshkeys/example-ssh-key
uid: 05aa53d5-38b8-4596-9ff4-dc7057f4fbbc
spec:
comment: user@example.com
keyType: ed25519apiVersion: generators.external-secrets.io/v1alpha1
kind: SSHKey
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: >
{"apiVersion":"generators.external-secrets.io/v1alpha1","kind":"SSHKey","metadata":{"annotations":{},"name":"example-rsa-key","namespace":"default"},"spec":{"comment":"rsa@example.com","keySize":4096,"keyType":"rsa"}}
creationTimestamp: "2025-07-30T09:52:56Z"
generation: 1
name: example-rsa-key
namespace: default
resourceVersion: "365651"
selfLink: >-
/apis/generators.external-secrets.io/v1alpha1/namespaces/default/sshkeys/example-rsa-key
uid: f5c78c16-4bb6-4fca-ab2e-88024a25c861
spec:
comment: rsa@example.com
keySize: 4096
keyType: rsaapiVersion: generators.external-secrets.io/v1alpha1
kind: SSHKey
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: >
{"apiVersion":"generators.external-secrets.io/v1alpha1","kind":"SSHKey","metadata":{"annotations":{},"name":"example-rsa-default-key","namespace":"default"},"spec":{"comment":"rsa-default@example.com","keyType":"rsa"}}
creationTimestamp: "2025-07-30T10:09:25Z"
generation: 1
name: example-rsa-default-key
namespace: default
resourceVersion: "367143"
selfLink: >-
/apis/generators.external-secrets.io/v1alpha1/namespaces/default/sshkeys/example-rsa-default-key
uid: f133a706-fd31-4525-9db1-259989aa2ab6
spec:
comment: rsa-default@example.com
keyType: rsaAll looks fine. |
Signed-off-by: Piotr Roszatycki <piotr.roszatycki@gmail.com>
Signed-off-by: Piotr Roszatycki <piotr.roszatycki@gmail.com>
Signed-off-by: Piotr Roszatycki <piotr.roszatycki@gmail.com>
Signed-off-by: Piotr Roszatycki <piotr.roszatycki@gmail.com>
Signed-off-by: Piotr Roszatycki <piotr.roszatycki@gmail.com>
Signed-off-by: Piotr Roszatycki <piotr.roszatycki@gmail.com>
Signed-off-by: Piotr Roszatycki <piotr.roszatycki@gmail.com>
Signed-off-by: Piotr Roszatycki <piotr.roszatycki@gmail.com>
|
Skarlso
approved these changes
Jul 30, 2025
alexlebens
pushed a commit
to alexlebens/infrastructure
that referenced
this pull request
Aug 3, 2025
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [external-secrets](https://github.com/external-secrets/external-secrets) | minor | `0.18.2` -> `0.19.0` | --- ### Release Notes <details> <summary>external-secrets/external-secrets (external-secrets)</summary> ### [`v0.19.0`](https://github.com/external-secrets/external-secrets/releases/tag/v0.19.0) [Compare Source](external-secrets/external-secrets@v0.18.2...v0.19.0) #### **BREAKING CHANGE** 🔴 🔴 BREAKING CHANGE 🔴 🔴 Please note that this a breaking change because our CRDs are now too big. Meaning a simple kubectl apply or Argo's default client side apply WILL NOT WORK! You have to add `--server-side` to kubectl apply and in argo add: ```yaml spec: project: default syncPolicy: automated: prune: true selfHeal: true syncOptions: - CreateNamespace=true - ServerSideApply=true ``` for it to correctly install the CRDs. Thank you. Image: `ghcr.io/external-secrets/external-secrets:v0.19.0` Image: `ghcr.io/external-secrets/external-secrets:v0.19.0-ubi` Image: `ghcr.io/external-secrets/external-secrets:v0.19.0-ubi-boringssl` #### What's Changed - chore: release helm chart for v0.18.2 by [@​Skarlso](https://github.com/Skarlso) in external-secrets/external-secrets#4985 - chore(deps): bump golang from `ee7ff13` to `10f549d` in /e2e by [@​dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#4997 - chore(deps): bump golang from `68932fa` to `68932fa` by [@​dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5000 - chore(deps): bump mkdocs-material from 9.6.14 to 9.6.15 in /hack/api-docs by [@​dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#4998 - chore(deps): bump anchore/sbom-action from 0.20.1 to 0.20.2 by [@​dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5001 - chore(deps): bump github/codeql-action from 3.29.1 to 3.29.2 by [@​dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5003 - chore(deps): bump aquasecurity/trivy-action from 0.31.0 to 0.32.0 by [@​dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5002 - fix: do not turn original value into string on value scope by [@​Skarlso](https://github.com/Skarlso) in external-secrets/external-secrets#5011 - fix: add uuid in edit and view clusterroles by [@​sylvainOL](https://github.com/sylvainOL) in external-secrets/external-secrets#5017 - chore: update dependencies by [@​eso-service-account-app](https://github.com/eso-service-account-app)\[bot] in external-secrets/external-secrets#4999 - fix: template data should not be the secret Data itself by [@​gusfcarvalho](https://github.com/gusfcarvalho) in external-secrets/external-secrets#5023 - Fix: Return appropriate error in ValidateStore by [@​prakash-218](https://github.com/prakash-218) in external-secrets/external-secrets#5019 - feat(helm): allow to set init containers by [@​rclsilver](https://github.com/rclsilver) in external-secrets/external-secrets#4745 - chore(deps): bump certifi from 2025.6.15 to 2025.7.14 in /hack/api-docs by [@​dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5032 - Fix: Remove root/buildinfo from ubi build files by [@​bainsy88](https://github.com/bainsy88) in external-secrets/external-secrets#5037 - chore(deps): bump ubi8/ubi from `19eae3d` to `c0b0729` by [@​dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5033 - chore(deps): bump golang from 1.24.4-bookworm to 1.24.5-bookworm in /e2e by [@​dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5029 - chore(deps): bump golang from 1.24.4 to 1.24.5 by [@​dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5034 - chore: update dependencies by [@​eso-service-account-app](https://github.com/eso-service-account-app)\[bot] in external-secrets/external-secrets#5031 - Add Red Hat OpenShift in Adopters by [@​KeenonLee](https://github.com/KeenonLee) in external-secrets/external-secrets#5039 - fix: remove authentication option with JWT token from STSSessionToken generator by [@​Skarlso](https://github.com/Skarlso) in external-secrets/external-secrets#5026 - fix: add validation constraints to ExternalSecretRewrite by [@​Aakkash-Suresh](https://github.com/Aakkash-Suresh) in external-secrets/external-secrets#5006 - fix: stability support matrix by [@​gusfcarvalho](https://github.com/gusfcarvalho) in external-secrets/external-secrets#5043 - docs(decoding-strategy): clarify base64 auto-detection limitations by [@​orymate](https://github.com/orymate) in external-secrets/external-secrets#5004 - feat(infisical): auth methods by [@​DanielHougaard](https://github.com/DanielHougaard) in external-secrets/external-secrets#5040 - chore(deps): bump alpine from 3.22.0 to 3.22.1 in /e2e by [@​dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5046 - chore(aws): parameterstore unit tests improvement by [@​ivankatliarchuk](https://github.com/ivankatliarchuk) in external-secrets/external-secrets#4986 - fix(helm): grafana dashboard: fix heatmaps to actually be heatmaps, not time series by [@​desaintmartin](https://github.com/desaintmartin) in external-secrets/external-secrets#5069 - chore(deps): bump sigstore/cosign-installer from 3.9.1 to 3.9.2 by [@​dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5047 - chore(deps): bump step-security/harden-runner from 2.12.2 to 2.13.0 by [@​dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5048 - chore(deps): bump golang from `ddf5200` to `daae04e` by [@​dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5049 - chore(deps): bump alpine from `8a1f59f` to `4bcff63` by [@​dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5051 - chore(deps): bump alpine from `8a1f59f` to `4bcff63` in /hack/api-docs by [@​dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5052 - chore(deps): bump mkdocs-material from 9.6.15 to 9.6.16 in /hack/api-docs by [@​dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5077 - Add SelfSubjectAccessReview as a fallback for failing SelfSubjectRulesReview by [@​alvin-rw](https://github.com/alvin-rw) in external-secrets/external-secrets#5025 - chore(deps): bump golang from `69adc37` to `ef8c5c7` in /e2e by [@​dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5076 - chore(deps): bump ubi8/ubi from `c0b0729` to `785d38c` by [@​dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5075 - chore(deps): bump github/codeql-action from 3.29.2 to 3.29.4 by [@​dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5072 - chore(deps): bump anchore/sbom-action from 0.20.2 to 0.20.4 by [@​dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5073 - SSHKey generator by [@​dex4er](https://github.com/dex4er) in external-secrets/external-secrets#5083 - fix: restore AWS credential chain resolution for ECRAuthorizationToken generator by [@​aditmeno](https://github.com/aditmeno) in external-secrets/external-secrets#5082 - fix(helm): grafana dashboard: add widget for sum of not ready secrets by [@​desaintmartin](https://github.com/desaintmartin) in external-secrets/external-secrets#5086 - feat(aws): secretsmanager to update/patch/delete tags by [@​ivankatliarchuk](https://github.com/ivankatliarchuk) in external-secrets/external-secrets#4984 - fix: update the e2e test with the new store status value by [@​Skarlso](https://github.com/Skarlso) in external-secrets/external-secrets#5089 - fix: correct usage of if in dlc and update for server side apply by [@​Skarlso](https://github.com/Skarlso) in external-secrets/external-secrets#5092 #### New Contributors - [@​sylvainOL](https://github.com/sylvainOL) made their first contribution in external-secrets/external-secrets#5017 - [@​prakash-218](https://github.com/prakash-218) made their first contribution in external-secrets/external-secrets#5019 - [@​rclsilver](https://github.com/rclsilver) made their first contribution in external-secrets/external-secrets#4745 - [@​bainsy88](https://github.com/bainsy88) made their first contribution in external-secrets/external-secrets#5037 - [@​KeenonLee](https://github.com/KeenonLee) made their first contribution in external-secrets/external-secrets#5039 - [@​orymate](https://github.com/orymate) made their first contribution in external-secrets/external-secrets#5004 - [@​desaintmartin](https://github.com/desaintmartin) made their first contribution in external-secrets/external-secrets#5069 - [@​alvin-rw](https://github.com/alvin-rw) made their first contribution in external-secrets/external-secrets#5025 - [@​dex4er](https://github.com/dex4er) made their first contribution in external-secrets/external-secrets#5083 - [@​aditmeno](https://github.com/aditmeno) made their first contribution in external-secrets/external-secrets#5082 **Full Changelog**: external-secrets/external-secrets@v0.18.2...v0.19.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xLjMiLCJ1cGRhdGVkSW5WZXIiOiI0MS4xLjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImNoYXJ0Il19--> Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/1114 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem Statement
Implements new generator that creates SSH key pair.
Related Issue
Fixes #5081
Proposed Changes
Implements it.
Checklist
git commit --signoffmake testmake reviewable