fix: do not turn original value into string on value scope by Skarlso · Pull Request #5011 · external-secrets/external-secrets

Skarlso · 2025-07-08T05:38:38Z

Problem Statement

What is the problem you're trying to solve?

Related Issue

Fixes #5010

Proposed Changes

How do you like to solve the issue and why?

Checklist

I have read the contribution guidelines
All commits are signed with git commit --signoff
My changes have reasonable test coverage
All tests pass with make test
I ensured my PR is ready for review with make reviewable

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

gusfcarvalho · 2025-07-09T10:08:46Z

This is also related to #4850

sonarqubecloud · 2025-07-09T10:12:41Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

…secrets#5011) Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: Prakash Kumar <work.prakash.218@gmail.com>

…secrets#5011) Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: asrormirzoev <asrormirzoev@yandex-team.ru>

* fix: do not turn original value into string on value scope (#5011) Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: Prakash Kumar <work.prakash.218@gmail.com> * Fix: Return appropriate error in ValidateStore Signed-off-by: Prakash Kumar <work.prakash.218@gmail.com> --------- Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: Prakash Kumar <work.prakash.218@gmail.com> Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [external-secrets](https://github.com/external-secrets/external-secrets) | minor | `0.18.2` -> `0.19.0` | --- ### Release Notes <details> <summary>external-secrets/external-secrets (external-secrets)</summary> ### [`v0.19.0`](https://github.com/external-secrets/external-secrets/releases/tag/v0.19.0) [Compare Source](external-secrets/external-secrets@v0.18.2...v0.19.0) #### **BREAKING CHANGE** 🔴 🔴 BREAKING CHANGE 🔴 🔴 Please note that this a breaking change because our CRDs are now too big. Meaning a simple kubectl apply or Argo's default client side apply WILL NOT WORK! You have to add `--server-side` to kubectl apply and in argo add: ```yaml spec: project: default syncPolicy: automated: prune: true selfHeal: true syncOptions: - CreateNamespace=true - ServerSideApply=true ``` for it to correctly install the CRDs. Thank you. Image: `ghcr.io/external-secrets/external-secrets:v0.19.0` Image: `ghcr.io/external-secrets/external-secrets:v0.19.0-ubi` Image: `ghcr.io/external-secrets/external-secrets:v0.19.0-ubi-boringssl` #### What's Changed - chore: release helm chart for v0.18.2 by [@Skarlso](https://github.com/Skarlso) in external-secrets/external-secrets#4985 - chore(deps): bump golang from `ee7ff13` to `10f549d` in /e2e by [@dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#4997 - chore(deps): bump golang from `68932fa` to `68932fa` by [@dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5000 - chore(deps): bump mkdocs-material from 9.6.14 to 9.6.15 in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#4998 - chore(deps): bump anchore/sbom-action from 0.20.1 to 0.20.2 by [@dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5001 - chore(deps): bump github/codeql-action from 3.29.1 to 3.29.2 by [@dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5003 - chore(deps): bump aquasecurity/trivy-action from 0.31.0 to 0.32.0 by [@dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5002 - fix: do not turn original value into string on value scope by [@Skarlso](https://github.com/Skarlso) in external-secrets/external-secrets#5011 - fix: add uuid in edit and view clusterroles by [@sylvainOL](https://github.com/sylvainOL) in external-secrets/external-secrets#5017 - chore: update dependencies by [@eso-service-account-app](https://github.com/eso-service-account-app)\[bot] in external-secrets/external-secrets#4999 - fix: template data should not be the secret Data itself by [@gusfcarvalho](https://github.com/gusfcarvalho) in external-secrets/external-secrets#5023 - Fix: Return appropriate error in ValidateStore by [@prakash-218](https://github.com/prakash-218) in external-secrets/external-secrets#5019 - feat(helm): allow to set init containers by [@rclsilver](https://github.com/rclsilver) in external-secrets/external-secrets#4745 - chore(deps): bump certifi from 2025.6.15 to 2025.7.14 in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5032 - Fix: Remove root/buildinfo from ubi build files by [@bainsy88](https://github.com/bainsy88) in external-secrets/external-secrets#5037 - chore(deps): bump ubi8/ubi from `19eae3d` to `c0b0729` by [@dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5033 - chore(deps): bump golang from 1.24.4-bookworm to 1.24.5-bookworm in /e2e by [@dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5029 - chore(deps): bump golang from 1.24.4 to 1.24.5 by [@dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5034 - chore: update dependencies by [@eso-service-account-app](https://github.com/eso-service-account-app)\[bot] in external-secrets/external-secrets#5031 - Add Red Hat OpenShift in Adopters by [@KeenonLee](https://github.com/KeenonLee) in external-secrets/external-secrets#5039 - fix: remove authentication option with JWT token from STSSessionToken generator by [@Skarlso](https://github.com/Skarlso) in external-secrets/external-secrets#5026 - fix: add validation constraints to ExternalSecretRewrite by [@Aakkash-Suresh](https://github.com/Aakkash-Suresh) in external-secrets/external-secrets#5006 - fix: stability support matrix by [@gusfcarvalho](https://github.com/gusfcarvalho) in external-secrets/external-secrets#5043 - docs(decoding-strategy): clarify base64 auto-detection limitations by [@orymate](https://github.com/orymate) in external-secrets/external-secrets#5004 - feat(infisical): auth methods by [@DanielHougaard](https://github.com/DanielHougaard) in external-secrets/external-secrets#5040 - chore(deps): bump alpine from 3.22.0 to 3.22.1 in /e2e by [@dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5046 - chore(aws): parameterstore unit tests improvement by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in external-secrets/external-secrets#4986 - fix(helm): grafana dashboard: fix heatmaps to actually be heatmaps, not time series by [@desaintmartin](https://github.com/desaintmartin) in external-secrets/external-secrets#5069 - chore(deps): bump sigstore/cosign-installer from 3.9.1 to 3.9.2 by [@dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5047 - chore(deps): bump step-security/harden-runner from 2.12.2 to 2.13.0 by [@dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5048 - chore(deps): bump golang from `ddf5200` to `daae04e` by [@dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5049 - chore(deps): bump alpine from `8a1f59f` to `4bcff63` by [@dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5051 - chore(deps): bump alpine from `8a1f59f` to `4bcff63` in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5052 - chore(deps): bump mkdocs-material from 9.6.15 to 9.6.16 in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5077 - Add SelfSubjectAccessReview as a fallback for failing SelfSubjectRulesReview by [@alvin-rw](https://github.com/alvin-rw) in external-secrets/external-secrets#5025 - chore(deps): bump golang from `69adc37` to `ef8c5c7` in /e2e by [@dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5076 - chore(deps): bump ubi8/ubi from `c0b0729` to `785d38c` by [@dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5075 - chore(deps): bump github/codeql-action from 3.29.2 to 3.29.4 by [@dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5072 - chore(deps): bump anchore/sbom-action from 0.20.2 to 0.20.4 by [@dependabot](https://github.com/dependabot)\[bot] in external-secrets/external-secrets#5073 - SSHKey generator by [@dex4er](https://github.com/dex4er) in external-secrets/external-secrets#5083 - fix: restore AWS credential chain resolution for ECRAuthorizationToken generator by [@aditmeno](https://github.com/aditmeno) in external-secrets/external-secrets#5082 - fix(helm): grafana dashboard: add widget for sum of not ready secrets by [@desaintmartin](https://github.com/desaintmartin) in external-secrets/external-secrets#5086 - feat(aws): secretsmanager to update/patch/delete tags by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in external-secrets/external-secrets#4984 - fix: update the e2e test with the new store status value by [@Skarlso](https://github.com/Skarlso) in external-secrets/external-secrets#5089 - fix: correct usage of if in dlc and update for server side apply by [@Skarlso](https://github.com/Skarlso) in external-secrets/external-secrets#5092 #### New Contributors - [@sylvainOL](https://github.com/sylvainOL) made their first contribution in external-secrets/external-secrets#5017 - [@prakash-218](https://github.com/prakash-218) made their first contribution in external-secrets/external-secrets#5019 - [@rclsilver](https://github.com/rclsilver) made their first contribution in external-secrets/external-secrets#4745 - [@bainsy88](https://github.com/bainsy88) made their first contribution in external-secrets/external-secrets#5037 - [@KeenonLee](https://github.com/KeenonLee) made their first contribution in external-secrets/external-secrets#5039 - [@orymate](https://github.com/orymate) made their first contribution in external-secrets/external-secrets#5004 - [@desaintmartin](https://github.com/desaintmartin) made their first contribution in external-secrets/external-secrets#5069 - [@alvin-rw](https://github.com/alvin-rw) made their first contribution in external-secrets/external-secrets#5025 - [@dex4er](https://github.com/dex4er) made their first contribution in external-secrets/external-secrets#5083 - [@aditmeno](https://github.com/aditmeno) made their first contribution in external-secrets/external-secrets#5082 **Full Changelog**: external-secrets/external-secrets@v0.18.2...v0.19.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/1114 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

fix: do not turn original value into string on value scope

7f2dc9d

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

Skarlso requested a review from a team as a code owner July 8, 2025 05:38

Skarlso requested a review from moolen July 8, 2025 05:38

gusfcarvalho approved these changes Jul 9, 2025

View reviewed changes

gusfcarvalho linked an issue Jul 9, 2025 that may be closed by this pull request

Option to disable auto base64 encoding for templateFrom.target = Data #4850

Closed

Merge branch 'main' into fix-casting-to-string-in-template

88ec5fe

Skarlso merged commit 1b3fc5d into external-secrets:main Jul 9, 2025
20 checks passed

skwig mentioned this pull request Sep 25, 2025

chore(deps): update helm release external-secrets to v0.20.4 skwig/homelab#44

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: do not turn original value into string on value scope#5011

fix: do not turn original value into string on value scope#5011
Skarlso merged 2 commits intoexternal-secrets:mainfrom
Skarlso:fix-casting-to-string-in-template

Skarlso commented Jul 8, 2025

Uh oh!

gusfcarvalho commented Jul 9, 2025

Uh oh!

sonarqubecloud bot commented Jul 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Skarlso commented Jul 8, 2025

Problem Statement

Related Issue

Proposed Changes

Checklist

Uh oh!

gusfcarvalho commented Jul 9, 2025

Uh oh!

sonarqubecloud bot commented Jul 9, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants